You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2025/02/02 08:20:24 UTC
[PR] Optimize lookup table in join operator [pinot]
Jackie-Jiang opened a new pull request, #14972:
URL: https://github.com/apache/pinot/pull/14972
Optimize lookup table (right table) in `HashJoinOperator`:
- Use primitive key map for single join key of type `INT`, `LONG`, `FLOAT`, `DOUBLE`
- Specialize unique keys case to avoid creating `List`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #14972:
URL: https://github.com/apache/pinot/pull/14972#issuecomment-2686775523
@Jackie-Jiang thanks for the info and you're right, it was actually the Object based structure that I was comparing earlier and I didn't notice that you're using a regular `HashMap` in `ObjectLookupTable` here 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #14972:
URL: https://github.com/apache/pinot/pull/14972#discussion_r1971085572
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/DoubleLookupTable.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import it.unimi.dsi.fastutil.doubles.Double2ObjectMap;
+import it.unimi.dsi.fastutil.doubles.Double2ObjectOpenHashMap;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+/**
+ * The {@code DoubleLookupTable} is a lookup table for double keys.
+ */
+@SuppressWarnings("unchecked")
+public class DoubleLookupTable extends LookupTable {
+ private final Double2ObjectOpenHashMap<Object> _lookupTable = new Double2ObjectOpenHashMap<>(INITIAL_CAPACITY);
+
+ @Override
+ public void addRow(Object key, Object[] row) {
+ _lookupTable.compute((double) key, (k, v) -> calculateValue(row, v));
+ }
+
+ @Override
+ public void finish() {
+ if (!_keysUnique) {
+ for (Double2ObjectMap.Entry<Object> entry : _lookupTable.double2ObjectEntrySet()) {
+ convertValueToList(entry);
+ }
+ }
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+ return _lookupTable.containsKey((double) key);
+ }
+
+ @Nullable
+ @Override
+ public Object[] lookup(Object key) {
+ return (Object[]) _lookupTable.get((double) key);
Review Comment:
Good catch! Fixed
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/FloatLookupTable.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import it.unimi.dsi.fastutil.floats.Float2ObjectMap;
+import it.unimi.dsi.fastutil.floats.Float2ObjectOpenHashMap;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+/**
+ * The {@code FloatLookupTable} is a lookup table for float keys.
+ */
+@SuppressWarnings("unchecked")
+public class FloatLookupTable extends LookupTable {
+ private final Float2ObjectOpenHashMap<Object> _lookupTable = new Float2ObjectOpenHashMap<>(INITIAL_CAPACITY);
+
+ @Override
+ public void addRow(Object key, Object[] row) {
+ _lookupTable.compute((float) key, (k, v) -> calculateValue(row, v));
+ }
+
+ @Override
+ public void finish() {
+ if (!_keysUnique) {
+ for (Float2ObjectMap.Entry<Object> entry : _lookupTable.float2ObjectEntrySet()) {
+ convertValueToList(entry);
+ }
+ }
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+ return _lookupTable.containsKey((float) key);
+ }
+
+ @Nullable
+ @Override
+ public Object[] lookup(Object key) {
+ return (Object[]) _lookupTable.get((float) key);
Review Comment:
Good catch! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on code in PR #14972:
URL: https://github.com/apache/pinot/pull/14972#discussion_r1971010755
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/LookupTable.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+public abstract class LookupTable {
+ // TODO: Make it configurable
+ protected static final int INITIAL_CAPACITY = 10000;
+
+ protected boolean _keysUnique = true;
+
+ /**
+ * Adds a row to the lookup table.
+ */
+ public abstract void addRow(Object key, Object[] row);
+
+ @SuppressWarnings("unchecked")
+ protected Object calculateValue(Object[] row, @Nullable Object currentValue) {
Review Comment:
nit: `computeNewValue` might be a more descriptive name for this method?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -123,69 +145,99 @@ protected List<Object[]> buildJoinedRows(TransferableBlock leftBlock)
case ANTI:
return buildJoinedDataBlockAnti(leftBlock);
default: { // INNER, LEFT, RIGHT, FULL
- return buildJoinedDataBlockDefault(leftBlock);
+ if (_rightTable.isKeysUnique()) {
Review Comment:
I've manually validated the changes here and the logic looks good but I think it would be nice to have more unit tests covering this at a more granular level.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/FloatLookupTable.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import it.unimi.dsi.fastutil.floats.Float2ObjectMap;
+import it.unimi.dsi.fastutil.floats.Float2ObjectOpenHashMap;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+/**
+ * The {@code FloatLookupTable} is a lookup table for float keys.
+ */
+@SuppressWarnings("unchecked")
+public class FloatLookupTable extends LookupTable {
+ private final Float2ObjectOpenHashMap<Object> _lookupTable = new Float2ObjectOpenHashMap<>(INITIAL_CAPACITY);
+
+ @Override
+ public void addRow(Object key, Object[] row) {
+ _lookupTable.compute((float) key, (k, v) -> calculateValue(row, v));
+ }
+
+ @Override
+ public void finish() {
+ if (!_keysUnique) {
+ for (Float2ObjectMap.Entry<Object> entry : _lookupTable.float2ObjectEntrySet()) {
+ convertValueToList(entry);
+ }
+ }
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+ return _lookupTable.containsKey((float) key);
+ }
+
+ @Nullable
+ @Override
+ public Object[] lookup(Object key) {
+ return (Object[]) _lookupTable.get((float) key);
Review Comment:
Same question as above. Looks like the `INT` / `LONG` / `OBJECT` versions of the lookup table don't have this issue. Am I missing something here? Even if the key is a `FLOAT` / `DOUBLE` type there could be more than one row having the same key right?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/LookupTable.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+public abstract class LookupTable {
+ // TODO: Make it configurable
+ protected static final int INITIAL_CAPACITY = 10000;
+
+ protected boolean _keysUnique = true;
+
+ /**
+ * Adds a row to the lookup table.
+ */
+ public abstract void addRow(Object key, Object[] row);
+
+ @SuppressWarnings("unchecked")
+ protected Object calculateValue(Object[] row, @Nullable Object currentValue) {
+ if (currentValue == null) {
+ return row;
+ } else {
+ _keysUnique = false;
+ if (currentValue instanceof List) {
+ ((List<Object[]>) currentValue).add(row);
+ return currentValue;
+ } else {
+ List<Object[]> rows = new ArrayList<>();
+ rows.add((Object[]) currentValue);
+ rows.add(row);
+ return rows;
+ }
+ }
+ }
+
+ /**
+ * Finishes adding rows to the lookup table. This method should be called after all rows are added to the lookup
+ * table, and before looking up rows.
+ */
+ public abstract void finish();
+
+ protected static void convertValueToList(Map.Entry<?, Object> entry) {
+ Object value = entry.getValue();
+ if (value instanceof Object[]) {
+ entry.setValue(Collections.singletonList(value));
+ }
+ }
+
+ /**
+ * Returns {@code true} when all the keys added to the lookup table are unique.
+ * When all keys are unique, the value of the lookup table is a single row ({@code Object[]}). When keys are not
+ * unique, the value of the lookup table is a list of rows ({@code List<Object[]>}).
+ */
+ public boolean isKeysUnique() {
Review Comment:
```suggestion
public boolean areKeysUnique() {
```
nit
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -123,69 +145,99 @@ protected List<Object[]> buildJoinedRows(TransferableBlock leftBlock)
case ANTI:
return buildJoinedDataBlockAnti(leftBlock);
default: { // INNER, LEFT, RIGHT, FULL
- return buildJoinedDataBlockDefault(leftBlock);
+ if (_rightTable.isKeysUnique()) {
Review Comment:
Actually on second thought, I think the tests in `HashJoinOperatorTest` are already covering many of these scenarios.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/DoubleLookupTable.java:
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import it.unimi.dsi.fastutil.doubles.Double2ObjectMap;
+import it.unimi.dsi.fastutil.doubles.Double2ObjectOpenHashMap;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+/**
+ * The {@code DoubleLookupTable} is a lookup table for double keys.
+ */
+@SuppressWarnings("unchecked")
+public class DoubleLookupTable extends LookupTable {
+ private final Double2ObjectOpenHashMap<Object> _lookupTable = new Double2ObjectOpenHashMap<>(INITIAL_CAPACITY);
+
+ @Override
+ public void addRow(Object key, Object[] row) {
+ _lookupTable.compute((double) key, (k, v) -> calculateValue(row, v));
+ }
+
+ @Override
+ public void finish() {
+ if (!_keysUnique) {
+ for (Double2ObjectMap.Entry<Object> entry : _lookupTable.double2ObjectEntrySet()) {
+ convertValueToList(entry);
+ }
+ }
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+ return _lookupTable.containsKey((double) key);
+ }
+
+ @Nullable
+ @Override
+ public Object[] lookup(Object key) {
+ return (Object[]) _lookupTable.get((double) key);
Review Comment:
Why are we casting to `Object[]` and returning `Object[]` here? The value could be a `List<Object[]>` if `_keysUnique` is `false` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #14972:
URL: https://github.com/apache/pinot/pull/14972#discussion_r1971092931
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/LookupTable.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.runtime.operator.join;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+
+public abstract class LookupTable {
+ // TODO: Make it configurable
+ protected static final int INITIAL_CAPACITY = 10000;
+
+ protected boolean _keysUnique = true;
+
+ /**
+ * Adds a row to the lookup table.
+ */
+ public abstract void addRow(Object key, Object[] row);
+
+ @SuppressWarnings("unchecked")
+ protected Object calculateValue(Object[] row, @Nullable Object currentValue) {
+ if (currentValue == null) {
+ return row;
+ } else {
+ _keysUnique = false;
+ if (currentValue instanceof List) {
+ ((List<Object[]>) currentValue).add(row);
+ return currentValue;
+ } else {
+ List<Object[]> rows = new ArrayList<>();
+ rows.add((Object[]) currentValue);
+ rows.add(row);
+ return rows;
+ }
+ }
+ }
+
+ /**
+ * Finishes adding rows to the lookup table. This method should be called after all rows are added to the lookup
+ * table, and before looking up rows.
+ */
+ public abstract void finish();
+
+ protected static void convertValueToList(Map.Entry<?, Object> entry) {
+ Object value = entry.getValue();
+ if (value instanceof Object[]) {
+ entry.setValue(Collections.singletonList(value));
+ }
+ }
+
+ /**
+ * Returns {@code true} when all the keys added to the lookup table are unique.
+ * When all keys are unique, the value of the lookup table is a single row ({@code Object[]}). When keys are not
+ * unique, the value of the lookup table is a list of rows ({@code List<Object[]>}).
+ */
+ public boolean isKeysUnique() {
Review Comment:
`is` prefix is kind of a convention for method returning `boolean`, so I prefer keeping it this way here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #14972:
URL: https://github.com/apache/pinot/pull/14972#issuecomment-2685996914
@yashmayya
> Are there any benchmark results showing performance improvements?
I've tested it in a custom build release and observed good performance when all keys are unique (iirc over 100% boost)
> I remember some other case where these primitive specific structures like Double2ObjectOpenHashMap were giving us much worse performance than a regular HashMap (although IIRC that was just for the build phase and not the lookup phase).
I guess it is due to the slower rehash (open map re-calculate the hash for all entries during rehash, java map caches the hash code for all entries), and that is why I didn't use open map when the key is `Object`. `Object2IntOpenHashMap` might give much worse performance comparing to regular java map, but primitive key open map should be fine. Are you sure you observed much worse performance for primitive double open map?
It should be super rare for user to join on a float/double key though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #14972:
URL: https://github.com/apache/pinot/pull/14972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Optimize lookup table in join operator [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14972:
URL: https://github.com/apache/pinot/pull/14972#issuecomment-2629312008
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14972?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `70.55215%` with `48 lines` in your changes missing coverage. Please review.
> Project coverage is 56.05%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e584d9d`)](https://app.codecov.io/gh/apache/pinot/commit/e584d9df623389794b82d5713e8c3e6f9f913d63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1663 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/14972?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...query/runtime/operator/join/DoubleLookupTable.java](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&filepath=pinot-query-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fquery%2Fruntime%2Foperator%2Fjoin%2FDoubleLookupTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9qb2luL0RvdWJsZUxvb2t1cFRhYmxlLmphdmE=) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../query/runtime/operator/join/FloatLookupTable.java](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&filepath=pinot-query-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fquery%2Fruntime%2Foperator%2Fjoin%2FFloatLookupTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9qb2luL0Zsb2F0TG9va3VwVGFibGUuamF2YQ==) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...t/query/runtime/operator/join/LongLookupTable.java](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&filepath=pinot-query-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fquery%2Fruntime%2Foperator%2Fjoin%2FLongLookupTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9qb2luL0xvbmdMb29rdXBUYWJsZS5qYXZh) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pinot/query/runtime/operator/HashJoinOperator.java](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&filepath=pinot-query-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fquery%2Fruntime%2Foperator%2FHashJoinOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9IYXNoSm9pbk9wZXJhdG9yLmphdmE=) | 87.20% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ot/query/runtime/operator/join/IntLookupTable.java](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&filepath=pinot-query-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fquery%2Fruntime%2Foperator%2Fjoin%2FIntLookupTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9qb2luL0ludExvb2t1cFRhYmxlLmphdmE=) | 91.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/14972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (e584d9d). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (e584d9d) |
>|------|------|------|
>|integration|7|0|
>|integration2|3|0|
>|temurin|12|2|
>|java-21|7|2|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|1|
>|unittests|5|2|
>|java-11|5|0|
>|unittests2|3|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #14972 +/- ##
============================================
- Coverage 61.75% 56.05% -5.71%
- Complexity 207 710 +503
============================================
Files 2436 2128 -308
Lines 133233 114662 -18571
Branches 20636 18457 -2179
============================================
- Hits 82274 64269 -18005
- Misses 44911 45134 +223
+ Partials 6048 5259 -789
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.05% <70.55%> (-5.58%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.03% <70.55%> (-5.72%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.00% <70.55%> (+28.28%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.05% <70.55%> (-5.71%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.05% <70.55%> (-5.70%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.05% <70.55%> (+9.15%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/14972/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/14972?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org