You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/26 05:44:42 UTC
[GitHub] [airflow] Bowrna opened a new pull request #19216: Typo fix
Bowrna opened a new pull request #19216:
URL: https://github.com/apache/airflow/pull/19216
I have added a typo fix in VS Code `Extensions` view part in TESTING.rst file under the title `To run unit tests from the Visual Studio Code:`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-954111604
I think the docs are fine - but the change contains more than typo fix it seems ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737158872
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
No pyenv doesn't emit the suggested lines at the end of the installation. Let me confirm if it applies to bash too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19216:
URL: https://github.com/apache/airflow/pull/19216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-954473100
i have rebased the branch @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna edited a comment on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna edited a comment on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-954473100
I have rebased the branch @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-953622931
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737204421
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
I have followed the instructions in [this](https://github.com/pyenv/pyenv/issues/1948) issue link to add these docs. It worked for me when I added the below instruction in the ~/.zshrc file.
I checked for bash and found [this](https://github.com/pyenv/pyenv#basic-github-checkout) guide where they have given similar instructions for bash too.
maybe I have to improve the instructions or point to the pyenv README.md for correct installation instruction as they have updated for zsh and bash? Please share your comments @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-953824731
I am not sure why the build docs test is failing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737460990
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
Yeah, that sounds like a good idea. Modify step 3 to say something like "Configure your shell's environment for Pyenv as suggested on [link to Pyenv's readme]"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737457066
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
It was not updated in the Pyenv readme when I raised and fixed this issue. But now the [README](https://github.com/pyenv/pyenv#readme) for Pyenv is updated with installation for specific OS and different shell terminals too.
To verify what instructions pyenv is emitting during installation I tried to install again and got the below message.
<img width="440" alt="Screenshot 2021-10-27 at 6 44 59 PM" src="https://user-images.githubusercontent.com/10162465/139073237-29131329-8872-4c48-a177-8cf0a4b8fa86.png">
can I modify the instruction to point to README for pyenv link to follow the instructions for proper installation? @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-954114371
I merged the other PR - so you should be able to rebase now @Bowrna and you should see only the typo-fix here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737643118
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
Yep. Indeed this will be much better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#issuecomment-951987278
Some code commits relevant to this [PR](https://github.com/apache/airflow/pull/19100) also got added into this PR. I didn't check out a branch earlier and did the commit from my main branch and raised my earlier PR. Hence you can see code changes relevant to that PR too. I am not sure how to fix it up and I will make sure that I will commit by properly branching out next time. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19216: Typo fix
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19216:
URL: https://github.com/apache/airflow/pull/19216#discussion_r737012396
##########
File path: CONTRIBUTORS_QUICK_START.rst
##########
@@ -147,29 +147,36 @@ Pyenv and setting up virtual-env
3. Add the lines suggested at the end of installation to ~/.bashrc
-4. Restart your shell so the path changes take effect and verifying installation
+4. If you are in macOS Big Sur 11.4, pyenv may face issues. It can be fixed by adding the below command to ~/.zshrc
Review comment:
This combined with the previous point (which mentioned `~/.bashrc`) is very confusing. Does this only apply if you are using Zsh? What about Bash? Doesn't pyenv emit "lines suggested at the end of the installation" when run in Zsh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org