You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/11/19 19:43:04 UTC
Review Request 71754: Improved performance of v1 operator API
GetState call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71754/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
This follow the same approach used in the GetAgents call;
serializing directly to protobuf or json from the in-memory
v0 state.
Diffs
-----
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
Diff: https://reviews.apache.org/r/71754/diff/1/
Testing
-------
Thanks,
Benjamin Mahler
Re: Review Request 71754: Improved performance of v1 operator API
GetState call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71754/#review218773
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Sekretenko
On Nov. 22, 2019, 6:28 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71754/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2019, 6:28 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
>
>
> Bugs: MESOS-10026
> https://issues.apache.org/jira/browse/MESOS-10026
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follow the same approach used in the GetAgents call;
> serializing directly to protobuf or json from the in-memory
> v0 state.
>
> Before:
> v0 '/state' response took 6.55 secs
> v1 'GetState' application/x-protobuf response took 24.08 secs
> v1 'GetState' application/json response took 22.76 secs
>
> After:
> v0 '/state' response took 8.00 secs
> v1 'GetState' application/x-protobuf response took 5.73 secs
> v1 'GetState' application/json response took 9.62 secs
>
>
> Diffs
> -----
>
> src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df
> src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f
>
>
> Diff: https://reviews.apache.org/r/71754/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71754: Improved performance of v1 operator API
GetState call.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71754/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 6:28 p.m.)
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Changes
-------
* Used default instead of all cases, per Andrei's suggestion, since it fits within our style guide recommendation: https://issues.apache.org/jira/browse/MESOS-3754
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
This follow the same approach used in the GetAgents call;
serializing directly to protobuf or json from the in-memory
v0 state.
Before:
v0 '/state' response took 6.55 secs
v1 'GetState' application/x-protobuf response took 24.08 secs
v1 'GetState' application/json response took 22.76 secs
After:
v0 '/state' response took 8.00 secs
v1 'GetState' application/x-protobuf response took 5.73 secs
v1 'GetState' application/json response took 9.62 secs
Diffs (updated)
-----
src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df
src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f
Diff: https://reviews.apache.org/r/71754/diff/3/
Changes: https://reviews.apache.org/r/71754/diff/2-3/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71754: Improved performance of v1 operator API
GetState call.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71754/
-----------------------------------------------------------
(Updated Nov. 22, 2019, 6:12 p.m.)
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Changes
-------
* Used NotAcceptable in place of BadRequest
* Added an UNREACHABLE()
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description (updated)
-------
This follow the same approach used in the GetAgents call;
serializing directly to protobuf or json from the in-memory
v0 state.
Before:
v0 '/state' response took 6.55 secs
v1 'GetState' application/x-protobuf response took 24.08 secs
v1 'GetState' application/json response took 22.76 secs
After:
v0 '/state' response took 8.00 secs
v1 'GetState' application/x-protobuf response took 5.73 secs
v1 'GetState' application/json response took 9.62 secs
Diffs (updated)
-----
src/master/http.cpp 1778664dddf19f9ab6d6c09ec35d64674ae488df
src/master/master.hpp 8a140650a016c8afbfb39729eba2b5e78ea81c5f
Diff: https://reviews.apache.org/r/71754/diff/2/
Changes: https://reviews.apache.org/r/71754/diff/1-2/
Testing (updated)
-------
make check
Thanks,
Benjamin Mahler