You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/08/11 09:28:48 UTC

[GitHub] [james-project] chibenwa commented on a diff in pull request #1119: JAMES-3802 Webadmin route to clean events of a dead letter group

chibenwa commented on code in PR #1119:
URL: https://github.com/apache/james-project/pull/1119#discussion_r943280315


##########
event-bus/api/src/test/java/org/apache/james/events/EventDeadLettersContract.java:
##########
@@ -197,6 +197,14 @@ default void removeShouldThrowWhenGroupIsNull() {
                 .isInstanceOf(IllegalArgumentException.class);
         }
 
+        @Test
+        default void removeAllEventsOfAGroupShouldThrowWhenGroupIsNull() {

Review Comment:
   What is the result of calling `remove(GROUPA)` then `groupsWithFailedEvents()` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org