You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "AndrewJSchofield (via GitHub)" <gi...@apache.org> on 2025/10/20 12:40:57 UTC

[PR] KAFKA-19814: WIP - Protocol and API changes for AcknowledgeType.RENEW [kafka]

AndrewJSchofield opened a new pull request, #20732:
URL: https://github.com/apache/kafka/pull/20732

   Part of KIP-1222. Define `AcknowledgeType.RENEW` and the new `ShareConsumer.acquisitionLockTimeoutMs()` method in the public API and protocol RPC schemas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19814: Protocol and API changes for KIP-1222 [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #20732:
URL: https://github.com/apache/kafka/pull/20732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19814: Protocol and API changes for AcknowledgeType.RENEW [kafka]

Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn commented on code in PR #20732:
URL: https://github.com/apache/kafka/pull/20732#discussion_r2465468378


##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java:
##########
@@ -137,6 +138,12 @@ public ShareFetchRequestData data() {
 
         @Override
         public ShareFetchRequest build(short version) {
+            if (version < 2) {
+                // The v1 does not support ShareAcquireMode Renew.

Review Comment:
   This comment needs to be revised? We are checking renewal, which is unrelated to ShareAcquireMode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19814: Protocol and API changes for AcknowledgeType.RENEW [kafka]

Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn commented on code in PR #20732:
URL: https://github.com/apache/kafka/pull/20732#discussion_r2465468378


##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java:
##########
@@ -137,6 +138,12 @@ public ShareFetchRequestData data() {
 
         @Override
         public ShareFetchRequest build(short version) {
+            if (version < 2) {
+                // The v1 does not support ShareAcquireMode Renew.

Review Comment:
   This comment needs to be revised? We are checking renewal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19814: Protocol and API changes for AcknowledgeType.RENEW [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #20732:
URL: https://github.com/apache/kafka/pull/20732#discussion_r2465497459


##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java:
##########
@@ -137,6 +138,12 @@ public ShareFetchRequestData data() {
 
         @Override
         public ShareFetchRequest build(short version) {
+            if (version < 2) {
+                // The v1 does not support ShareAcquireMode Renew.

Review Comment:
   Entirely correct. Thanks :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19814: Protocol and API changes for AcknowledgeType.RENEW [kafka]

Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn commented on code in PR #20732:
URL: https://github.com/apache/kafka/pull/20732#discussion_r2465468378


##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java:
##########
@@ -137,6 +138,12 @@ public ShareFetchRequestData data() {
 
         @Override
         public ShareFetchRequest build(short version) {
+            if (version < 2) {
+                // The v1 does not support ShareAcquireMode Renew.

Review Comment:
   nit: This comment needs to be revised? We are checking renewal, which is unrelated to ShareAcquireMode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org