[jira] [Commented] (AVRO-1175) BinaryData keeps a thread local reference after completing a compare, preventing compared arrays from being GC'd

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465229#comment-13465229 ] 

Doug Cutting commented on AVRO-1175:
------------------------------------

I don't yet see how this could cause an OutOfMemoryError.  This will leak at most two buffers per live thread.  Once a thread dies, all ThreadLocal values should be collectable.  Do you see more live instances of BinaryData.Decoders than there are live threads?
                
> BinaryData keeps a thread local reference after completing a compare, preventing compared arrays from being GC'd
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1175
>                 URL: https://issues.apache.org/jira/browse/AVRO-1175
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sandy Ryza
>
> BinaryData holds on to BinaryDecoders as thread local variables (so it doesn't have to make new ones for each compare?).  When a compare is completed, the BinaryDecoder still keeps a reference to the ByteArrayByteSource, which stops its underlying byte array from being garbage collected.
> This is causing an OutOfMemoryError in reducers when shuffling with MR2.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira