You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/25 22:09:55 UTC
[GitHub] [kafka] wcarlson5 opened a new pull request #11808: KAFKA-13281: list all named topologies
wcarlson5 opened a new pull request #11808:
URL: https://github.com/apache/kafka/pull/11808
List all the named topologies that have been added to this client
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on a change in pull request #11808: KAFKA-13281: list all named topologies
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on a change in pull request #11808:
URL: https://github.com/apache/kafka/pull/11808#discussion_r815227626
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -149,6 +149,10 @@ public NamedTopologyBuilder newNamedTopologyBuilder(final String topologyName) {
return Optional.ofNullable(topologyMetadata.lookupBuilderForNamedTopology(name)).map(InternalTopologyBuilder::namedTopology);
}
+ public Collection<NamedTopology> getAllTopologies() {
+ return getAllTopologies();
Review comment:
oops. I though I was calling that on topology metadata. Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11808: KAFKA-13281: list all named topologies
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11808:
URL: https://github.com/apache/kafka/pull/11808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #11808: KAFKA-13281: list all named topologies
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #11808:
URL: https://github.com/apache/kafka/pull/11808#discussion_r815205312
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -149,6 +149,10 @@ public NamedTopologyBuilder newNamedTopologyBuilder(final String topologyName) {
return Optional.ofNullable(topologyMetadata.lookupBuilderForNamedTopology(name)).map(InternalTopologyBuilder::namedTopology);
}
+ public Collection<NamedTopology> getAllTopologies() {
+ return getAllTopologies();
Review comment:
this looks like an infinite loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org