You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2021/08/24 14:21:49 UTC
[brooklyn-ui] branch master updated: fix scrolling on mozilla
This is an automated email from the ASF dual-hosted git repository.
heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-ui.git
The following commit(s) were added to refs/heads/master by this push:
new 69f6109 fix scrolling on mozilla
69f6109 is described below
commit 69f61094e7e498c1d4e994efed9bf13e2d709871
Author: Alex Heneveld <al...@cloudsoftcorp.com>
AuthorDate: Tue Aug 24 14:55:09 2021 +0100
fix scrolling on mozilla
---
ui-modules/catalog/app/views/bundle/type/type.state.js | 10 +++++-----
ui-modules/utils/br-core/br-core.less | 11 +++++++++++
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/ui-modules/catalog/app/views/bundle/type/type.state.js b/ui-modules/catalog/app/views/bundle/type/type.state.js
index 258d6d1..ddf67e6 100644
--- a/ui-modules/catalog/app/views/bundle/type/type.state.js
+++ b/ui-modules/catalog/app/views/bundle/type/type.state.js
@@ -154,7 +154,7 @@ export function typeController($scope, $state, $stateParams, $q, $uibModal, brBr
effectors: { header: 'Effector' },
}, {
field: 'name',
- template: '<samp>{{ item.name }}</samp>',
+ template: '<div class="mozilla-td-scroll-fix"><samp>{{ item.name }}</samp></div>',
width: 100,
colspan: 3,
});
@@ -171,7 +171,7 @@ export function typeController($scope, $state, $stateParams, $q, $uibModal, brBr
effectors: { field: 'returnType' },
}, {
field: 'type',
- template: '<span class="label-color column-for-type oneline label label-success">{{ item[column.field] }}</span>',
+ template: '<div class="mozilla-td-scroll-fix"><span class="label-color column-for-type oneline label label-success">{{ item[column.field] }}</span></div>',
colspan: 3,
} );
@@ -183,7 +183,7 @@ export function typeController($scope, $state, $stateParams, $q, $uibModal, brBr
field: 'description',
width: 150,
colspan: 6,
- template: '<md-field raw-data="::item[column.field]"></md-field>',
+ template: '<div class="mozilla-td-scroll-fix"><md-field raw-data="::item[column.field]"></md-field></div>',
tdClass: 'column-for-description',
});
@@ -191,7 +191,7 @@ export function typeController($scope, $state, $stateParams, $q, $uibModal, brBr
config: {
field: 'defaultValue',
colspan: 3,
- template: '<samp>{{ item.defaultValue }}</samp>',
+ template: '<div class="mozilla-td-scroll-fix"><samp>{{ item.defaultValue }}</samp></div>',
},
});
@@ -237,7 +237,7 @@ export function typeController($scope, $state, $stateParams, $q, $uibModal, brBr
width: 120,
colspan: 2,
hidden: true,
- template: '<samp>{{ item.constraints }}</samp>',
+ template: '<div class="mozilla-td-scroll-fix"><samp>{{ item.constraints }}</samp></div>',
}
});
addColumn({
diff --git a/ui-modules/utils/br-core/br-core.less b/ui-modules/utils/br-core/br-core.less
index 4660ffe..a3d2672 100644
--- a/ui-modules/utils/br-core/br-core.less
+++ b/ui-modules/utils/br-core/br-core.less
@@ -19,3 +19,14 @@
@import (reference) "~bootstrap/less/bootstrap";
@import "style/_components";
+
+.mozilla-td-scroll-fix {
+ /* scroll on a td doesn't work on mozilla; wrapping content in a div with this class fixes that.
+ * see: https://stackoverflow.com/questions/14547722/how-to-control-overflow-of-table-cell-in-firefox
+ * https://lists.w3.org/Archives/Public/www-style/2006Mar/0030.html#replies
+ */
+ margin: -8px;
+ padding: 8px;
+ overflow: auto;
+}
+