You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by GitBox <gi...@apache.org> on 2017/11/25 22:26:15 UTC

[GitHub] lbruun commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers

lbruun commented on issue #293: [NETBEANS-161] edited some malformed/forgotten license headers
URL: https://github.com/apache/incubator-netbeans/pull/293#issuecomment-346970296
 
 
   I think all changes in this PR looks good.
   
   The reason why #282 didn't find these ones is because it deliberately erred on the side of caution: it only considered files which started with `"**<LF> * Licensed to ....`. For this reason it didn't find:
   
   1. Files that uses Windows line endings  (which is wrong, but that's another story)
   2. Files where there are some spaces before the license header actually starts
   3. Java files where the license header comes _after_ the package declaration (also wrong)
   
   This PR has found and fixes (2) and (3) as far as I can tell.  
   All good.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services