[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3214: Fix cast date type return wrong result

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3214: Fix cast date type return wrong result
URL: https://github.com/apache/incubator-doris/pull/3214#discussion_r399163380
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java
 ##########
 @@ -319,7 +319,7 @@ protected void toThrift(TExprNode msg) {
 
     @Override
     protected Expr uncheckedCastTo(Type targetType) throws AnalysisException {
-        if (targetType.isDateType()) {
+        if (targetType.equals(this.type)) {
 
 Review comment:
   Are you sure only change this point is enough？
   Do we need to change this point:
   FunctionCallExpr::analyzeImpl
   ```
           Type[] args = fn.getArgs();
           if (args.length > 0) {
               // Implicitly cast all the children to match the function if necessary
               for (int i = 0; i < argTypes.length; ++i) {
                   // For varargs, we must compare with the last type in callArgs.argTypes.
                   int ix = Math.min(args.length - 1, i);
                   if (!argTypes[i].matchesType(args[ix]) && !(
                           argTypes[i].isDateType() && args[ix].isDateType())) {
                       uncheckedCastChild(args[ix], i);
                       //if (argTypes[i] != args[ix]) castChild(args[ix], i);
                   }
               }
           }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org