You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/20 07:28:29 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
MartijnVisser opened a new pull request, #20317:
URL: https://github.com/apache/flink/pull/20317
## What is the purpose of the change
* Mark StreamingFileSink as deprecated
## Brief change log
* Added `@Deprecated` annotation and included link to replacement
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20317:
URL: https://github.com/apache/flink/pull/20317#issuecomment-1189946478
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1f4e736f407d600a912a4d8d36f847c2719c3754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f4e736f407d600a912a4d8d36f847c2719c3754",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f4e736f407d600a912a4d8d36f847c2719c3754 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a diff in pull request #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #20317:
URL: https://github.com/apache/flink/pull/20317#discussion_r926548473
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java:
##########
@@ -86,8 +86,10 @@
* arrived after the checkpoint from which we restore.
*
* @param <IN> Type of the elements emitted by this sink
+ * @deprecated Use {@link org.apache.flink.connector.file.sink.FileSink} instead.
*/
@PublicEvolving
+@Deprecated
Review Comment:
In python class `StreamingFileSink`, we can also add the deprecated note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #20317:
URL: https://github.com/apache/flink/pull/20317#discussion_r926591406
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/StreamingFileSink.java:
##########
@@ -86,8 +86,10 @@
* arrived after the checkpoint from which we restore.
*
* @param <IN> Type of the elements emitted by this sink
+ * @deprecated Use {@link org.apache.flink.connector.file.sink.FileSink} instead.
*/
@PublicEvolving
+@Deprecated
Review Comment:
Thanks, I'll add it there too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20317:
URL: https://github.com/apache/flink/pull/20317#issuecomment-1192285089
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #20317: [FLINK-27188][Connector][StreamingFileSink] Mark StreamingFileSink as deprecated
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #20317:
URL: https://github.com/apache/flink/pull/20317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org