You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2015/12/09 16:01:56 UTC

[GitHub] flink pull request: [FLINK-2936] Fix ClassCastException for Event-...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1448

    [FLINK-2936] Fix ClassCastException for Event-Time source

    Before, would throw a ClassCastException when emitting watermarks with
    timestamp/watermark multiplexing disabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink watermark-fix-processing-time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1448
    
----
commit bbc44047052dd795a26540888255fae911668053
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2015-12-09T15:00:12Z

    [FLINK-2936] Fix ClassCastException for Event-Time source
    
    Before, would throw a ClassCastException when emitting watermarks with
    timestamp/watermark multiplexing disabled.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2936] Fix ClassCastException for Event-...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1448#issuecomment-163940693
  
    Probably okay to do it like this.
    How hard is it to pass the "timestamps" flag into the constructor of the SourceOperator, rather than through the runtime context?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2936] Fix ClassCastException for Event-...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1448


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2936] Fix ClassCastException for Event-...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1448#issuecomment-163918357
  
    @StephanEwen do we want to fix it like this now, or do we want to integrate it into the StreamRecordSerializer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---