[jira] [Work logged] (LOG4NET-671) LoggingEvent does not correctly dispose WindowsIdentity

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LOG4NET-671?focusedWorklogId=697104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-697104 ]

ASF GitHub Bot logged work on LOG4NET-671:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Dec/21 06:59
            Start Date: 16/Dec/21 06:59
    Worklog Time Spent: 10m 
      Work Description: fluffynuts merged pull request #79:
URL: https://github.com/apache/logging-log4net/pull/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 697104)
    Remaining Estimate: 0h
            Time Spent: 10m

> LoggingEvent does not correctly dispose WindowsIdentity
> -------------------------------------------------------
>
>                 Key: LOG4NET-671
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-671
>             Project: Log4net
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.10
>            Reporter: Jan Hindermann
>            Priority: Major
>         Attachments: Stacktrace.png, UndisposedHandles.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> LoggingEvent uses the [WindowsIdentity|https://docs.microsoft.com/en-us/dotnet/api/system.security.principal.windowsidentity?view=net-5.0] class to get the current user. After the required information is retrieved from the object, it is not disposed correctly, which means that it ends up in the finalizer queue (or rather, the handle objects that WindowsIdentity uses internally).
> During the runtime of a sufficiently large application, this can lead to the finalizer queue having to process several thousands of undisposed objects. As the CLR does not guarantee that the finalizer thread will run, the memory may fill up with leaked objects.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)