You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by fchaillou <gi...@git.apache.org> on 2014/03/31 23:25:30 UTC
[GitHub] camel pull request: Configuration enhancement
GitHub user fchaillou opened a pull request:
https://github.com/apache/camel/pull/126
Configuration enhancement
Kafka provides a lot of property configurable for both consumer and producer (See http://kafka.apache.org/documentation.html#consumerconfigs and http://kafka.apache.org/documentation.html#producerconfigs).
With this change, all this properties are exposed to the camel component.
To do that, i splitted the configuration in its own class so that it is possible to create a separated configuration that can be reused.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fchaillou/camel configurationEnhancement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit b4ef76e2bbde737663cfabadb81cd7cfdcafe434
Author: Fabien Chaillou <fa...@gmail.com>
Date: 2014-03-27T15:51:41Z
Extract Configuration in its own class
Kafka has a lot of configuration options that needs to be exposed.
As a start, the configuration is splitted in its own configuration class
commit 3cf3396e154101290fa5b16fd6a69e6b96588404
Author: Fabien Chaillou <fa...@gmail.com>
Date: 2014-03-27T19:50:25Z
Add configuration for all Kafka properties
Complete the configuration Object to be able to configure all the properties from Kafka
commit dbdbd548fd086c046380df529753495bc4fc9636
Author: Fabien Chaillou <fa...@gmail.com>
Date: 2014-03-31T15:56:22Z
Dont force default values
Kafka provides default value to most of the properties if we dont set them in our Properties.
Instead of forcing default in the Configuration, we set everything to null and only add it if it is non-null
commit b68b5bd8c56fb3e17b65158fe836ae8da261777e
Author: Fabien Chaillou <fa...@gmail.com>
Date: 2014-03-31T21:17:46Z
Kafka: Use the configured properties in the consumer
Use in the consumer the properties configured through the KafkaConfiguration bean
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request: Configuration enhancement
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:
https://github.com/apache/camel/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---