You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/11 21:09:43 UTC
[GitHub] [nifi] mr1716 opened a new pull request, #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
mr1716 opened a new pull request, #6120:
URL: https://github.com/apache/nifi/pull/6120
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [[NIFI-10090](https://issues.apache.org/jira/browse/NIFI-10090) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
URL: https://github.com/apache/nifi/pull/6120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6120:
URL: https://github.com/apache/nifi/pull/6120#issuecomment-1153898482
@exceptionfactory ok. I have removed the Google KMS change and kept the Guava. Is there anything else I need to do and was that not the right change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6120:
URL: https://github.com/apache/nifi/pull/6120#issuecomment-1153894272
> @exceptionfactory Thanks for the information. I reviewed and approved, but is there anything I need to do? Should I submit a new PR instead? I also noticed that updating the Google-KMS software would resolve another JIRA ticket for Java Protobuf, as the newer version of Google KMS. Is there anything else I need to do for this?
In light of the fact that upgrading Google KMS and other libraries impacts more than just Guava, it would be better to handle that in a separate Jira issue and separate PR.
If you can make the version adjustment to the Guava version in the other files, I can approve the workflow run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6120:
URL: https://github.com/apache/nifi/pull/6120#issuecomment-1153892348
@exceptionfactory Thanks for the information. I reviewed and approved, but is there anything I need to do? Should I submit a new PR instead?
I also noticed that updating the Google-KMS software would resolve another JIRA ticket for Java Protobuf, as the newer version of Google KMS. Is there anything else I need to do for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6120:
URL: https://github.com/apache/nifi/pull/6120#issuecomment-1153886955
@exceptionfactory Thanks for the feedback. So would this change upgrade the remaining use of Guava from 28 to the most recent version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6120:
URL: https://github.com/apache/nifi/pull/6120#discussion_r895680722
##########
nifi-commons/nifi-property-protection-gcp/pom.xml:
##########
@@ -53,6 +53,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-kms</artifactId>
+ <version>2.4.0</version>
Review Comment:
This version change should be removed. The `google-cloud-kms` version is managed through the `libraries-bom` dependency.
##########
nifi-registry/nifi-registry-core/pom.xml:
##########
@@ -130,7 +130,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
- <version>28.0-jre</version>
+ <version>31.0.1-jre</version>
Review Comment:
The latest version of Guava is `31.1-jre`, which contains several updates to what is included in `31.0.1-jre`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mr1716 commented on pull request #6120: NIFI-10090 Update Guava JRE 28 in NiFi Toolkit to latest version
Posted by GitBox <gi...@apache.org>.
mr1716 commented on PR #6120:
URL: https://github.com/apache/nifi/pull/6120#issuecomment-1153909834
@exceptionfactory Yes sir. Once this is approved, I will either remove or update this fork accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org