You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/11 07:19:06 UTC

[GitHub] [flink] slinkydeveloper commented on a diff in pull request #19410: [FLINK-15635][table] Now EnvironmentSettings accepts the user ClassLoader

slinkydeveloper commented on code in PR #19410:
URL: https://github.com/apache/flink/pull/19410#discussion_r847015104


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java:
##########
@@ -621,7 +626,7 @@ public void registerTemporarySystemFunction(
     }
 
     @SuppressWarnings("unchecked")
-    private void validateAndPrepareFunction(CatalogFunction function)
+    private CatalogFunction validateAndPrepareFunction(CatalogFunction function)

Review Comment:
   yep, all of them now use the returned value here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org