You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "thiagoelg (via GitHub)" <gi...@apache.org> on 2024/04/04 20:23:53 UTC
Re: [PR] incubator-kie-issues#389: Include environment variables on all KIE Sandbox-related images to configure the port used [incubator-kie-tools]
thiagoelg commented on code in PR #2225:
URL: https://github.com/apache/incubator-kie-tools/pull/2225#discussion_r1552379819
##########
packages/kie-sandbox-image/entrypoint.sh:
##########
@@ -2,8 +2,11 @@
# Copying the KIE Sandbox assets here is essential for when the container is running with the readOnlyRootFilesystem flag.
# But, just like any other directory modified during runtime, the /var/www/html must be a mounted volume in the container in this case.
Review Comment:
This comment is related to the `cp -R` command below, we should keep them together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org