You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2017/03/27 21:47:44 UTC
[GitHub] trafficserver pull request #1612: Changed some of the HTTP/2 enums to enum c...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/1612
Changed some of the HTTP/2 enums to enum classes and found a bug
found a bug in is_client_state_writeable()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver http2_enum_class
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1612
----
commit 45dcbd5d72d90ad3b77bda97ccc7e4a1451cd3b8
Author: Bryan Call <bc...@apache.org>
Date: 2017-03-24T16:41:12Z
Changed some of the HTTP/2 enums to enum classes and found a comparison bug
in is_client_state_writeable()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Moved to 7.1.0, I think this is a good patch + good fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1612: Changed some of the HTTP/2 enums to enum c...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1806/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1697/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Cherry picked to 7.1.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/368/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/107/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/124/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/236/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1612
clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/110/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/1612
@bryancall Looks good to me, but I don't see which part was the bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---