Re: [jira] Commented: (SHINDIG-816) Stax based parser for GadgetSpec and MessageBundle

[Henning Schmiedehausen <hg...@googlemail.com>]

I would definitely create a test branch for this before putting it
into the trunk. I run this version pretty much unchanged (some minor
patches) on our internal code base and it looks pretty good. However,
I am tired of chasing the tail of 1.0.x or even trunk, so I don't
check against this code base much these days. I will catch up once I
feel that there is some stabilization happening. We are pushing for
our big release end of February so I don't have  time to rebase
patches again and again.

    Ciao
         Henning


On Tue, Jan 20, 2009 at 18:07, Paul Lindner (JIRA) <ji...@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/SHINDIG-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665686#action_12665686 ]
>
> Paul Lindner commented on SHINDIG-816:
> --------------------------------------
>
> it's an improvement to be sure.  Code looks pretty decent based on quick eyeball scan.
>
> My only thought here is that it would be beneficial to generate classes using jaxb/xjc or jaxme2 and the xjc maven plugin.  This would allow for dealing with future spec changes more easily.  However that's just a wish :)
>
>
>
>
>
>> Stax based parser for GadgetSpec and MessageBundle
>> --------------------------------------------------
>>
>>                 Key: SHINDIG-816
>>                 URL: https://issues.apache.org/jira/browse/SHINDIG-816
>>             Project: Shindig
>>          Issue Type: Improvement
>>          Components: Gadget Rendering Server (Java)
>>    Affects Versions: 1.0.x-incubating
>>            Reporter: Henning Schmiedehausen
>>         Attachments: RELEASE-NOTES, svn-stax.patch
>>
>>
>> This is a large patch which I don't expect to go in without some discussion. However, we have to start at some point.
>> As I wrote before (and those of you following my mails to the dev list probably know), I need some features that the current, DOM based parser for GadgetSpec and related to this, for MessageBundle, can not deliver. I need to reconstruct gadget specs from the objects, passing through other namespaced elements and a number of additional requirements which, in the end, led to a complete new implementation of the GadgetSpec parser using Stax.
>> The attached RELEASE-NOTES file describes in ample detail the problems that I have encountered and the quirks I discovered while dissecting the existing parser.
>> And, while it does not really matter with good caching, preliminary tests show that the parser is measurably faster than the old DOM parser. If it were possible to stream XML into it, there would be even more performance improvements.
>> Given the fact, that we will soon see other namespaces in the gadget spec (the whole templating stuff), this should be much easier and more readable doable using this parser approach.
>> A code review ist at http://codereview.appspot.com/11676
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>