You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Daniel Gredler (JIRA)" <ji...@apache.org> on 2011/03/16 01:09:29 UTC
[jira] Created: (NET-374) ParserInitializationException doesn't use
standard JDK exception chaining
ParserInitializationException doesn't use standard JDK exception chaining
-------------------------------------------------------------------------
Key: NET-374
URL: https://issues.apache.org/jira/browse/NET-374
Project: Commons Net
Issue Type: Improvement
Components: FTP
Affects Versions: 2.2
Reporter: Daniel Gredler
Priority: Minor
ParserInitializationException appears to have its own rootCause instance variable, rather than using RuntimeException's constructors which allow a cause to be specified (ParserInitializationException extends RuntimeException). So for example on line 53 of this class [1], I would expect to see a simple invocation to super(message, rootCause).
The reason this has come up is that we're logging these exceptions using log4j, but because ParserInitializationException doesn't use the standard JDK exception chaining, we don't get visibility into the root issue in the logs.
This was discussed briefly on the user mailing list [2].
[1] http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/ParserInitializationException.java?view=markup
[2] http://markmail.org/thread/6hn3doow352ic6ho
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (NET-374) ParserInitializationException doesn't
use standard JDK exception chaining
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-374.
----------------------
Resolution: Fixed
> ParserInitializationException doesn't use standard JDK exception chaining
> -------------------------------------------------------------------------
>
> Key: NET-374
> URL: https://issues.apache.org/jira/browse/NET-374
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 2.2
> Reporter: Daniel Gredler
> Priority: Minor
>
> ParserInitializationException appears to have its own rootCause instance variable, rather than using RuntimeException's constructors which allow a cause to be specified (ParserInitializationException extends RuntimeException). So for example on line 53 of this class [1], I would expect to see a simple invocation to super(message, rootCause).
> The reason this has come up is that we're logging these exceptions using log4j, but because ParserInitializationException doesn't use the standard JDK exception chaining, we don't get visibility into the root issue in the logs.
> This was discussed briefly on the user mailing list [2].
> [1] http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/ParserInitializationException.java?view=markup
> [2] http://markmail.org/thread/6hn3doow352ic6ho
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-374) ParserInitializationException doesn't
use standard JDK exception chaining
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated NET-374:
---------------------
Fix Version/s: 3.0
> ParserInitializationException doesn't use standard JDK exception chaining
> -------------------------------------------------------------------------
>
> Key: NET-374
> URL: https://issues.apache.org/jira/browse/NET-374
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 2.2
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 3.0
>
>
> ParserInitializationException appears to have its own rootCause instance variable, rather than using RuntimeException's constructors which allow a cause to be specified (ParserInitializationException extends RuntimeException). So for example on line 53 of this class [1], I would expect to see a simple invocation to super(message, rootCause).
> The reason this has come up is that we're logging these exceptions using log4j, but because ParserInitializationException doesn't use the standard JDK exception chaining, we don't get visibility into the root issue in the logs.
> This was discussed briefly on the user mailing list [2].
> [1] http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/ParserInitializationException.java?view=markup
> [2] http://markmail.org/thread/6hn3doow352ic6ho
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira