You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by Dan Haywood <da...@haywood-associates.co.uk> on 2013/10/07 09:35:54 UTC
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Hi Martin, Michael...
I've been keeping the master branch up to date of the bootstrap3 fork of
Isis [1], but I noticed that there haven't been any commits recently on the
ISIS-537 branch [2].
Questions:
* are you currently busy on other stuff? (that's fine if you are), or
* are you blocked / do I need to get more involved here?
As you can imagine, I'm really keen to see this work progress, so if
there's anything I can provide to help ensure ongoing progress, I'd like to
do that.
Also, given things are currently quiet on that branch, would now be a good
time for me to do a rebase of ISIS-537 onto master?
Cheers
Dan
[1] https://github.com/l0rdn1kk0n/isis
[2] https://github.com/l0rdn1kk0n/isis/commits/ISIS-537
On 18 September 2013 13:22, Dan Haywood <da...@haywood-associates.co.uk>wrote:
>
>
> On 18 September 2013 13:13, Martin Grigorov <mg...@apache.org> wrote:
>
>> On Wed, Sep 18, 2013 at 1:28 PM, Martin Grigorov <mgrigorov@apache.org
>> >wrote:
>>
>> > I was able to run quickstart_wicket_restful_jdo webapp successfully.
>> >
>> > I see Jetty 6.x is used. I'll update it to 8.x.
>> >
>>
>> I've updated it to Jetty 7.6.13.v20130916 because I've noticed that there
>> are dependencies to geronimo-servlet-2.5 and jsp-2.1.
>> Jetty 8.x requires Servlet API 3.x and maybe there are ISIS users with
>> older web servers.
>>
>
> given how young Isis is, that's probably unlikely. But I agree there's no
> need to go all the way to Servlet API 3.x at this time.
>
>
>
>>
>> Why there is a dependency to JSP-2.1 ? I hope ISIS doesn't use JSPs.
>>
>>
> It doesn't. Or rather, it shouldn't. Or rather, the Wicket viewer
> doesn't. Would be curious to see why that's added. If you can't remove it
> easily, I'll help.
>
>
>
>>
>> > Additionally I'll add Start.java (as in Wicket's quickstart) because it
>> > allows to develop/debug much faster. Especially when you use DCEVM (
>> >
>> http://blog.jetbrains.com/idea/2013/07/get-true-hot-swap-in-java-with-dcevm-and-intellij-idea/
>> > ).
>> >
>>
>
> ok
>
>
>> > At the moment ISIS-537 branch build fails with some issue related to
>> > having several versions of ANTLR. We will have to fix it.
>>
>
> this might be an interaction with JDO/DN; have seen something related to
> this before.
>
>
>
>> >
>> > Also we (me and Michael) prefer to use Twitter Bootstrap 3, so we will
>> > have to use Wicket Bootstrap 0.8.5-SNAPSHOT<
>> https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/bootstrap3> build
>> > from 'bootstrap3' branch. At the moment these snapshots are not deployed
>> > anywhere so every developer will have to clone Wicket Bootstrap project
>> > locally and install it (as simple as "mvn clean install")
>> >
>>
>
> ok
>
>
>
>>
>> Twitter Bootstrap 3 doesn't support IE8. Is that a problem for ISIS ?
>>
>
> Nope, that's fine.
>
> Cheers
> Dan
>
>
>
>
>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Oct 11, 2013 at 1:48 PM, Dan Haywood
<da...@haywood-associates.co.uk>wrote:
> If Isis running on 1.6 ends up being a blocker for you, then I'm happy to
> start a discussion thread on dropping 1.6 support in Isis and only
> running/building on 1.7.
>
Yep. This is option 3). And I think the best if possible.
Wicket 7.0 will also mandate JDK 1.7
> I believe that at least some other Apache projects have dropped 1.6
> support; would be interesting to see if we get any pushback in the Isis
> community.
>
> Dan
>
>
>
> On 11 October 2013 10:11, Martin Grigorov <mg...@apache.org> wrote:
>
> > There are some issues with the new versions of
> > Wicket-Bootstrap:0.9.0-SNAPSHOT (WB) and Wicket-Webjars:0.3.1 (WW) - they
> > are built with JDK 1.7.
> > Since ISIS is built (and run) with 1.6 this causes problems.
> >
> > Options:
> > 1) at the moment WB doesn't depend on any JD 1.7 feature so to be able to
> > work on ISIS I have a local build with 1.6:
> > diff --git i/pom.xml w/pom.xml
> > index c0ef00d..d00e17a 100644
> > --- i/pom.xml
> > +++ w/pom.xml
> > @@ -37,6 +37,7 @@
> > </modules>
> >
> > <properties>
> > + <mvn.build.java.version>1.6</mvn.build.java.version>
> > <github.global.server>github</github.global.server>
> >
> > 2) run any ISIS + Wicket viewer apps with JDK 1.7
> >
> > About 1) : I understand why Michael wants to use 1.7 - it is 2013.
> Several
> > years ago in one of my projects we needed to produce jars for clients
> which
> > were deploying on older web containers. We used some Maven plugin that I
> > cannot find right now, but this plugin produced Maven artifacts with
> > classifiers like "jdk1.4" and "jdk1.5". Maybe this is an option for WB
> and
> > WW projects.
> >
> >
> >
> > On Fri, Oct 11, 2013 at 11:50 AM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >
> >> Hi,
> >>
> >> @Dan: what is your development workflow for ISIS ?
> >> Because of the problem with Intellij IDEA's plugin for DataNucleus I
> >> cannot use Start.java and the only way to run the demo application is
> via
> >> 'mvn jetty:run[-exploded]'. But if I make a change in Wicket Viewer
> code I
> >> need to run 'mvn install' and to restart Jetty. This takes a lot of
> time.
> >> Since you don't use Start.java I guess you have some other flow that is
> >> faster than mine.
> >>
> >>
> >>
> >>
> >> On Tue, Oct 8, 2013 at 1:52 PM, Martin Grigorov <mgrigorov@apache.org
> >wrote:
> >>
> >>>
> >>>
> >>>
> >>> On Tue, Oct 8, 2013 at 1:29 PM, Dan Haywood <
> >>> dan@haywood-associates.co.uk> wrote:
> >>>
> >>>>
> >>>> On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org>
> wrote:
> >>>>
> >>>>> I've pulled the latest changes and now I cannot start the app because
> >>>>> of:
> >>>>> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type
> >>>>> cannot be used in operation
> >>>>> at org.hsqldb.error.Error.error(Unknown Source)
> >>>>> at org.hsqldb.error.Error.error(Unknown Source)
> >>>>> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
> >>>>> at
> >>>>> org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
> >>>>> Source)
> >>>>> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
> >>>>> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
> >>>>> ....
> >>>>>
> >>>>> I don't use any plugins for JDO in Intellij IDEA. Last time the app
> >>>>> was starting fine.
> >>>>>
> >>>>
> >>>> Hmm, well... that error means that the DOM objects have not been
> >>>> enhanced. You will need to do enhancement by one means or another (I
> can't
> >>>> quite see how it would have started otherwise). If IntelliJ runs
> Maven
> >>>> plugins, then that would have done it, I guess.
> >>>>
> >>>> IntelliJ does have a DN plugin, probably worth spending the time
> >>>> getting it configured.
> >>>>
> >>>
> >>> It was working OK last time. Not sure how.
> >>>
> >>> Just installed IntelliJ plugin but it fails with:
> >>>
> >>> 25003 [ApplicationImpl pooled thread 4] ERROR
> >>> #com.intellij.application.impl.ApplicationImpl - null
> >>> java.lang.NullPointerException
> >>> at
> >>>
> org.datanucleus.ide.idea.IdeaProjectUtils.packageToPath(IdeaProjectUtils.java:192)
> >>> at org.datanucleus.ide.idea.DNEComputable$1.run(DNEComputable.java:631)
> >>> at
> >>>
> com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:929)
> >>> at
> >>>
> org.datanucleus.ide.idea.DNEComputable.getAnnotatedClassFiles(DNEComputable.java:595)
> >>> at
> >>>
> org.datanucleus.ide.idea.DNEProjectComponent.createAnnotatedClassFilesGuiModel(DNEProjectComponent.java:384)
> >>> at
> >>>
> org.datanucleus.ide.idea.DNEProjectComponent.getGuiState(DNEProjectComponent.java:277)
> >>> at
> >>>
> org.datanucleus.ide.idea.DNEProjectComponent.createComponent(DNEProjectComponent.java:212)
> >>> at
> >>>
> com.intellij.openapi.options.newEditor.OptionsEditor$Simple.<init>(OptionsEditor.java:1270)
> >>> ....
> >>>
> >>>
> >>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>>
> >>>>> On command line I cannot build ISIS-537 branch because of :
> >>>>>
> >>>>> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
> >>>>> isis-viewer-wicket-ui ---
> >>>>> [WARNING]
> >>>>> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
> >>>>> dependency are:
> >>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
> >>>>>
> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
> >>>>> +-org.webjars:bootstrap:3.0.0
> >>>>> +-org.webjars:jquery:1.9.0
> >>>>> and
> >>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
> >>>>>
> >>>>>
> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
> >>>>> +-org.webjars:jquery-ui:1.10.2-1
> >>>>> +-org.webjars:jquery:1.9.1
> >>>>>
> >>>>> Can we disable these checks for this branch ?
> >>>>>
> >>>>>
> >>>> yeah, happy to. Could you add a comment (or even better, a subtask)
> >>>> to the ISIS-537 ticket as something to address prior to remerging in
> the
> >>>> future.
> >>>>
> >>>
> >>> ISIS-556
> >>>
> >>>
> >>>>
> >>>> Thx
> >>>> Dan
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>>
> >>>>> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <
> mgrigorov@apache.org
> >>>>> > wrote:
> >>>>>
> >>>>>> Hi Dan,
> >>>>>>
> >>>>>> I'll work on this task this week again.
> >>>>>>
> >>>>>> Thx
> >>>>
> >>>>
> >>>
> >>
> >
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
If Isis running on 1.6 ends up being a blocker for you, then I'm happy to
start a discussion thread on dropping 1.6 support in Isis and only
running/building on 1.7.
I believe that at least some other Apache projects have dropped 1.6
support; would be interesting to see if we get any pushback in the Isis
community.
Dan
On 11 October 2013 10:11, Martin Grigorov <mg...@apache.org> wrote:
> There are some issues with the new versions of
> Wicket-Bootstrap:0.9.0-SNAPSHOT (WB) and Wicket-Webjars:0.3.1 (WW) - they
> are built with JDK 1.7.
> Since ISIS is built (and run) with 1.6 this causes problems.
>
> Options:
> 1) at the moment WB doesn't depend on any JD 1.7 feature so to be able to
> work on ISIS I have a local build with 1.6:
> diff --git i/pom.xml w/pom.xml
> index c0ef00d..d00e17a 100644
> --- i/pom.xml
> +++ w/pom.xml
> @@ -37,6 +37,7 @@
> </modules>
>
> <properties>
> + <mvn.build.java.version>1.6</mvn.build.java.version>
> <github.global.server>github</github.global.server>
>
> 2) run any ISIS + Wicket viewer apps with JDK 1.7
>
> About 1) : I understand why Michael wants to use 1.7 - it is 2013. Several
> years ago in one of my projects we needed to produce jars for clients which
> were deploying on older web containers. We used some Maven plugin that I
> cannot find right now, but this plugin produced Maven artifacts with
> classifiers like "jdk1.4" and "jdk1.5". Maybe this is an option for WB and
> WW projects.
>
>
>
> On Fri, Oct 11, 2013 at 11:50 AM, Martin Grigorov <mg...@apache.org>wrote:
>
>> Hi,
>>
>> @Dan: what is your development workflow for ISIS ?
>> Because of the problem with Intellij IDEA's plugin for DataNucleus I
>> cannot use Start.java and the only way to run the demo application is via
>> 'mvn jetty:run[-exploded]'. But if I make a change in Wicket Viewer code I
>> need to run 'mvn install' and to restart Jetty. This takes a lot of time.
>> Since you don't use Start.java I guess you have some other flow that is
>> faster than mine.
>>
>>
>>
>>
>> On Tue, Oct 8, 2013 at 1:52 PM, Martin Grigorov <mg...@apache.org>wrote:
>>
>>>
>>>
>>>
>>> On Tue, Oct 8, 2013 at 1:29 PM, Dan Haywood <
>>> dan@haywood-associates.co.uk> wrote:
>>>
>>>>
>>>> On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org> wrote:
>>>>
>>>>> I've pulled the latest changes and now I cannot start the app because
>>>>> of:
>>>>> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type
>>>>> cannot be used in operation
>>>>> at org.hsqldb.error.Error.error(Unknown Source)
>>>>> at org.hsqldb.error.Error.error(Unknown Source)
>>>>> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
>>>>> at
>>>>> org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
>>>>> Source)
>>>>> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
>>>>> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
>>>>> ....
>>>>>
>>>>> I don't use any plugins for JDO in Intellij IDEA. Last time the app
>>>>> was starting fine.
>>>>>
>>>>
>>>> Hmm, well... that error means that the DOM objects have not been
>>>> enhanced. You will need to do enhancement by one means or another (I can't
>>>> quite see how it would have started otherwise). If IntelliJ runs Maven
>>>> plugins, then that would have done it, I guess.
>>>>
>>>> IntelliJ does have a DN plugin, probably worth spending the time
>>>> getting it configured.
>>>>
>>>
>>> It was working OK last time. Not sure how.
>>>
>>> Just installed IntelliJ plugin but it fails with:
>>>
>>> 25003 [ApplicationImpl pooled thread 4] ERROR
>>> #com.intellij.application.impl.ApplicationImpl - null
>>> java.lang.NullPointerException
>>> at
>>> org.datanucleus.ide.idea.IdeaProjectUtils.packageToPath(IdeaProjectUtils.java:192)
>>> at org.datanucleus.ide.idea.DNEComputable$1.run(DNEComputable.java:631)
>>> at
>>> com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:929)
>>> at
>>> org.datanucleus.ide.idea.DNEComputable.getAnnotatedClassFiles(DNEComputable.java:595)
>>> at
>>> org.datanucleus.ide.idea.DNEProjectComponent.createAnnotatedClassFilesGuiModel(DNEProjectComponent.java:384)
>>> at
>>> org.datanucleus.ide.idea.DNEProjectComponent.getGuiState(DNEProjectComponent.java:277)
>>> at
>>> org.datanucleus.ide.idea.DNEProjectComponent.createComponent(DNEProjectComponent.java:212)
>>> at
>>> com.intellij.openapi.options.newEditor.OptionsEditor$Simple.<init>(OptionsEditor.java:1270)
>>> ....
>>>
>>>
>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> On command line I cannot build ISIS-537 branch because of :
>>>>>
>>>>> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
>>>>> isis-viewer-wicket-ui ---
>>>>> [WARNING]
>>>>> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
>>>>> dependency are:
>>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>>>> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
>>>>> +-org.webjars:bootstrap:3.0.0
>>>>> +-org.webjars:jquery:1.9.0
>>>>> and
>>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>>>>
>>>>> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
>>>>> +-org.webjars:jquery-ui:1.10.2-1
>>>>> +-org.webjars:jquery:1.9.1
>>>>>
>>>>> Can we disable these checks for this branch ?
>>>>>
>>>>>
>>>> yeah, happy to. Could you add a comment (or even better, a subtask)
>>>> to the ISIS-537 ticket as something to address prior to remerging in the
>>>> future.
>>>>
>>>
>>> ISIS-556
>>>
>>>
>>>>
>>>> Thx
>>>> Dan
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>>
>>>>> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mgrigorov@apache.org
>>>>> > wrote:
>>>>>
>>>>>> Hi Dan,
>>>>>>
>>>>>> I'll work on this task this week again.
>>>>>>
>>>>>> Thx
>>>>
>>>>
>>>
>>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
There are some issues with the new versions of
Wicket-Bootstrap:0.9.0-SNAPSHOT (WB) and Wicket-Webjars:0.3.1 (WW) - they
are built with JDK 1.7.
Since ISIS is built (and run) with 1.6 this causes problems.
Options:
1) at the moment WB doesn't depend on any JD 1.7 feature so to be able to
work on ISIS I have a local build with 1.6:
diff --git i/pom.xml w/pom.xml
index c0ef00d..d00e17a 100644
--- i/pom.xml
+++ w/pom.xml
@@ -37,6 +37,7 @@
</modules>
<properties>
+ <mvn.build.java.version>1.6</mvn.build.java.version>
<github.global.server>github</github.global.server>
2) run any ISIS + Wicket viewer apps with JDK 1.7
About 1) : I understand why Michael wants to use 1.7 - it is 2013. Several
years ago in one of my projects we needed to produce jars for clients which
were deploying on older web containers. We used some Maven plugin that I
cannot find right now, but this plugin produced Maven artifacts with
classifiers like "jdk1.4" and "jdk1.5". Maybe this is an option for WB and
WW projects.
On Fri, Oct 11, 2013 at 11:50 AM, Martin Grigorov <mg...@apache.org>wrote:
> Hi,
>
> @Dan: what is your development workflow for ISIS ?
> Because of the problem with Intellij IDEA's plugin for DataNucleus I
> cannot use Start.java and the only way to run the demo application is via
> 'mvn jetty:run[-exploded]'. But if I make a change in Wicket Viewer code I
> need to run 'mvn install' and to restart Jetty. This takes a lot of time.
> Since you don't use Start.java I guess you have some other flow that is
> faster than mine.
>
>
>
>
> On Tue, Oct 8, 2013 at 1:52 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>>
>>
>>
>> On Tue, Oct 8, 2013 at 1:29 PM, Dan Haywood <dan@haywood-associates.co.uk
>> > wrote:
>>
>>>
>>> On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org> wrote:
>>>
>>>> I've pulled the latest changes and now I cannot start the app because
>>>> of:
>>>> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type cannot
>>>> be used in operation
>>>> at org.hsqldb.error.Error.error(Unknown Source)
>>>> at org.hsqldb.error.Error.error(Unknown Source)
>>>> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
>>>> at
>>>> org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
>>>> Source)
>>>> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
>>>> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
>>>> ....
>>>>
>>>> I don't use any plugins for JDO in Intellij IDEA. Last time the app was
>>>> starting fine.
>>>>
>>>
>>> Hmm, well... that error means that the DOM objects have not been
>>> enhanced. You will need to do enhancement by one means or another (I can't
>>> quite see how it would have started otherwise). If IntelliJ runs Maven
>>> plugins, then that would have done it, I guess.
>>>
>>> IntelliJ does have a DN plugin, probably worth spending the time getting
>>> it configured.
>>>
>>
>> It was working OK last time. Not sure how.
>>
>> Just installed IntelliJ plugin but it fails with:
>>
>> 25003 [ApplicationImpl pooled thread 4] ERROR
>> #com.intellij.application.impl.ApplicationImpl - null
>> java.lang.NullPointerException
>> at
>> org.datanucleus.ide.idea.IdeaProjectUtils.packageToPath(IdeaProjectUtils.java:192)
>> at org.datanucleus.ide.idea.DNEComputable$1.run(DNEComputable.java:631)
>> at
>> com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:929)
>> at
>> org.datanucleus.ide.idea.DNEComputable.getAnnotatedClassFiles(DNEComputable.java:595)
>> at
>> org.datanucleus.ide.idea.DNEProjectComponent.createAnnotatedClassFilesGuiModel(DNEProjectComponent.java:384)
>> at
>> org.datanucleus.ide.idea.DNEProjectComponent.getGuiState(DNEProjectComponent.java:277)
>> at
>> org.datanucleus.ide.idea.DNEProjectComponent.createComponent(DNEProjectComponent.java:212)
>> at
>> com.intellij.openapi.options.newEditor.OptionsEditor$Simple.<init>(OptionsEditor.java:1270)
>> ....
>>
>>
>>
>>>
>>>
>>>
>>>
>>>
>>>>
>>>> On command line I cannot build ISIS-537 branch because of :
>>>>
>>>> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
>>>> isis-viewer-wicket-ui ---
>>>> [WARNING]
>>>> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
>>>> dependency are:
>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>>> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
>>>> +-org.webjars:bootstrap:3.0.0
>>>> +-org.webjars:jquery:1.9.0
>>>> and
>>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>>>
>>>> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
>>>> +-org.webjars:jquery-ui:1.10.2-1
>>>> +-org.webjars:jquery:1.9.1
>>>>
>>>> Can we disable these checks for this branch ?
>>>>
>>>>
>>> yeah, happy to. Could you add a comment (or even better, a subtask) to
>>> the ISIS-537 ticket as something to address prior to remerging in the
>>> future.
>>>
>>
>> ISIS-556
>>
>>
>>>
>>> Thx
>>> Dan
>>>
>>>
>>>
>>>
>>>
>>>>
>>>> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mg...@apache.org>wrote:
>>>>
>>>>> Hi Dan,
>>>>>
>>>>> I'll work on this task this week again.
>>>>>
>>>>> Thx
>>>
>>>
>>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Oct 11, 2013 at 1:37 PM, Dan Haywood
<da...@haywood-associates.co.uk>wrote:
>
>
> On 11 October 2013 09:50, Martin Grigorov <mg...@apache.org> wrote:
>
>> Hi,
>>
>> @Dan: what is your development workflow for ISIS ?
>>
>
>
> I use Eclipse with the DN plugin, and the use the .launch files in
> ide/eclipse/launch to run up Isis' WebServer class, that in turn spins up
> an embedded jetty.
>
> I've just recorded and uploaded a very rough-n-ready screencast to show in
> a bit more detail [1].
>
Thanks! I'll check it soon.
>
> HTH
> Dan
>
> [1] http://www.youtube.com/watch?v=ljwQiGsVq2A&feature=youtu.be
>
>
>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
On 11 October 2013 09:50, Martin Grigorov <mg...@apache.org> wrote:
> Hi,
>
> @Dan: what is your development workflow for ISIS ?
>
I use Eclipse with the DN plugin, and the use the .launch files in
ide/eclipse/launch to run up Isis' WebServer class, that in turn spins up
an embedded jetty.
I've just recorded and uploaded a very rough-n-ready screencast to show in
a bit more detail [1].
HTH
Dan
[1] http://www.youtube.com/watch?v=ljwQiGsVq2A&feature=youtu.be
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
@Dan: what is your development workflow for ISIS ?
Because of the problem with Intellij IDEA's plugin for DataNucleus I cannot
use Start.java and the only way to run the demo application is via 'mvn
jetty:run[-exploded]'. But if I make a change in Wicket Viewer code I need
to run 'mvn install' and to restart Jetty. This takes a lot of time.
Since you don't use Start.java I guess you have some other flow that is
faster than mine.
On Tue, Oct 8, 2013 at 1:52 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>
>
> On Tue, Oct 8, 2013 at 1:29 PM, Dan Haywood <da...@haywood-associates.co.uk>wrote:
>
>>
>> On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org> wrote:
>>
>>> I've pulled the latest changes and now I cannot start the app because of:
>>> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type cannot
>>> be used in operation
>>> at org.hsqldb.error.Error.error(Unknown Source)
>>> at org.hsqldb.error.Error.error(Unknown Source)
>>> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
>>> at
>>> org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
>>> Source)
>>> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
>>> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
>>> ....
>>>
>>> I don't use any plugins for JDO in Intellij IDEA. Last time the app was
>>> starting fine.
>>>
>>
>> Hmm, well... that error means that the DOM objects have not been
>> enhanced. You will need to do enhancement by one means or another (I can't
>> quite see how it would have started otherwise). If IntelliJ runs Maven
>> plugins, then that would have done it, I guess.
>>
>> IntelliJ does have a DN plugin, probably worth spending the time getting
>> it configured.
>>
>
> It was working OK last time. Not sure how.
>
> Just installed IntelliJ plugin but it fails with:
>
> 25003 [ApplicationImpl pooled thread 4] ERROR
> #com.intellij.application.impl.ApplicationImpl - null
> java.lang.NullPointerException
> at
> org.datanucleus.ide.idea.IdeaProjectUtils.packageToPath(IdeaProjectUtils.java:192)
> at org.datanucleus.ide.idea.DNEComputable$1.run(DNEComputable.java:631)
> at
> com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:929)
> at
> org.datanucleus.ide.idea.DNEComputable.getAnnotatedClassFiles(DNEComputable.java:595)
> at
> org.datanucleus.ide.idea.DNEProjectComponent.createAnnotatedClassFilesGuiModel(DNEProjectComponent.java:384)
> at
> org.datanucleus.ide.idea.DNEProjectComponent.getGuiState(DNEProjectComponent.java:277)
> at
> org.datanucleus.ide.idea.DNEProjectComponent.createComponent(DNEProjectComponent.java:212)
> at
> com.intellij.openapi.options.newEditor.OptionsEditor$Simple.<init>(OptionsEditor.java:1270)
> ....
>
>
>
>>
>>
>>
>>
>>
>>>
>>> On command line I cannot build ISIS-537 branch because of :
>>>
>>> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
>>> isis-viewer-wicket-ui ---
>>> [WARNING]
>>> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
>>> dependency are:
>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
>>> +-org.webjars:bootstrap:3.0.0
>>> +-org.webjars:jquery:1.9.0
>>> and
>>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>>
>>> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
>>> +-org.webjars:jquery-ui:1.10.2-1
>>> +-org.webjars:jquery:1.9.1
>>>
>>> Can we disable these checks for this branch ?
>>>
>>>
>> yeah, happy to. Could you add a comment (or even better, a subtask) to
>> the ISIS-537 ticket as something to address prior to remerging in the
>> future.
>>
>
> ISIS-556
>
>
>>
>> Thx
>> Dan
>>
>>
>>
>>
>>
>>>
>>> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mg...@apache.org>wrote:
>>>
>>>> Hi Dan,
>>>>
>>>> I'll work on this task this week again.
>>>>
>>>> Thx
>>
>>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Oct 8, 2013 at 1:29 PM, Dan Haywood <da...@haywood-associates.co.uk>wrote:
>
> On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org> wrote:
>
>> I've pulled the latest changes and now I cannot start the app because of:
>> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type cannot
>> be used in operation
>> at org.hsqldb.error.Error.error(Unknown Source)
>> at org.hsqldb.error.Error.error(Unknown Source)
>> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
>> at
>> org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
>> Source)
>> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
>> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
>> ....
>>
>> I don't use any plugins for JDO in Intellij IDEA. Last time the app was
>> starting fine.
>>
>
> Hmm, well... that error means that the DOM objects have not been enhanced.
> You will need to do enhancement by one means or another (I can't quite see
> how it would have started otherwise). If IntelliJ runs Maven plugins, then
> that would have done it, I guess.
>
> IntelliJ does have a DN plugin, probably worth spending the time getting
> it configured.
>
It was working OK last time. Not sure how.
Just installed IntelliJ plugin but it fails with:
25003 [ApplicationImpl pooled thread 4] ERROR
#com.intellij.application.impl.ApplicationImpl - null
java.lang.NullPointerException
at
org.datanucleus.ide.idea.IdeaProjectUtils.packageToPath(IdeaProjectUtils.java:192)
at org.datanucleus.ide.idea.DNEComputable$1.run(DNEComputable.java:631)
at
com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:929)
at
org.datanucleus.ide.idea.DNEComputable.getAnnotatedClassFiles(DNEComputable.java:595)
at
org.datanucleus.ide.idea.DNEProjectComponent.createAnnotatedClassFilesGuiModel(DNEProjectComponent.java:384)
at
org.datanucleus.ide.idea.DNEProjectComponent.getGuiState(DNEProjectComponent.java:277)
at
org.datanucleus.ide.idea.DNEProjectComponent.createComponent(DNEProjectComponent.java:212)
at
com.intellij.openapi.options.newEditor.OptionsEditor$Simple.<init>(OptionsEditor.java:1270)
....
>
>
>
>
>
>>
>> On command line I cannot build ISIS-537 branch because of :
>>
>> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
>> isis-viewer-wicket-ui ---
>> [WARNING]
>> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
>> dependency are:
>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
>> +-org.webjars:bootstrap:3.0.0
>> +-org.webjars:jquery:1.9.0
>> and
>> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>>
>> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
>> +-org.webjars:jquery-ui:1.10.2-1
>> +-org.webjars:jquery:1.9.1
>>
>> Can we disable these checks for this branch ?
>>
>>
> yeah, happy to. Could you add a comment (or even better, a subtask) to
> the ISIS-537 ticket as something to address prior to remerging in the
> future.
>
ISIS-556
>
> Thx
> Dan
>
>
>
>
>
>>
>> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mg...@apache.org>wrote:
>>
>>> Hi Dan,
>>>
>>> I'll work on this task this week again.
>>>
>>> Thx
>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Dan Haywood <da...@haywood-associates.co.uk>.
On 8 October 2013 10:57, Martin Grigorov <mg...@apache.org> wrote:
> I've pulled the latest changes and now I cannot start the app because of:
> Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type cannot be
> used in operation
> at org.hsqldb.error.Error.error(Unknown Source)
> at org.hsqldb.error.Error.error(Unknown Source)
> at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
> at org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
> Source)
> at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
> at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
> ....
>
> I don't use any plugins for JDO in Intellij IDEA. Last time the app was
> starting fine.
>
Hmm, well... that error means that the DOM objects have not been enhanced.
You will need to do enhancement by one means or another (I can't quite see
how it would have started otherwise). If IntelliJ runs Maven plugins, then
that would have done it, I guess.
IntelliJ does have a DN plugin, probably worth spending the time getting it
configured.
>
> On command line I cannot build ISIS-537 branch because of :
>
> [INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
> isis-viewer-wicket-ui ---
> [WARNING]
> Dependency convergence error for org.webjars:jquery:1.9.0 paths to
> dependency are:
> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
> +-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
> +-org.webjars:bootstrap:3.0.0
> +-org.webjars:jquery:1.9.0
> and
> +-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
>
> +-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
> +-org.webjars:jquery-ui:1.10.2-1
> +-org.webjars:jquery:1.9.1
>
> Can we disable these checks for this branch ?
>
>
yeah, happy to. Could you add a comment (or even better, a subtask) to the
ISIS-537 ticket as something to address prior to remerging in the future.
Thx
Dan
>
> On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mg...@apache.org>wrote:
>
>> Hi Dan,
>>
>> I'll work on this task this week again.
>>
>> Thx
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
I've pulled the latest changes and now I cannot start the app because of:
Caused by: org.hsqldb.HsqlException: column of LOB or ARRAY type cannot be
used in operation
at org.hsqldb.error.Error.error(Unknown Source)
at org.hsqldb.error.Error.error(Unknown Source)
at org.hsqldb.Constraint.setColumnsIndexes(Unknown Source)
at org.hsqldb.ParserDDL.compileAlterTableAddForeignKeyConstraint(Unknown
Source)
at org.hsqldb.ParserDDL.compileAlterTable(Unknown Source)
at org.hsqldb.ParserDDL.compileAlter(Unknown Source)
....
I don't use any plugins for JDO in Intellij IDEA. Last time the app was
starting fine.
On command line I cannot build ISIS-537 branch because of :
[INFO] --- maven-enforcer-plugin:1.2:enforce (validate-enforce) @
isis-viewer-wicket-ui ---
[WARNING]
Dependency convergence error for org.webjars:jquery:1.9.0 paths to
dependency are:
+-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
+-de.agilecoders.wicket:wicket-bootstrap-core:0.9.0-20131001.073459-3
+-org.webjars:bootstrap:3.0.0
+-org.webjars:jquery:1.9.0
and
+-org.apache.isis.viewer:isis-viewer-wicket-ui:1.3.0-SNAPSHOT
+-de.agilecoders.wicket:wicket-bootstrap-extensions:0.9.0-20131001.073550-3
+-org.webjars:jquery-ui:1.10.2-1
+-org.webjars:jquery:1.9.1
Can we disable these checks for this branch ?
On Tue, Oct 8, 2013 at 12:40 PM, Martin Grigorov <mg...@apache.org>wrote:
> Hi Dan,
>
> I'll work on this task this week again.
>
> On Mon, Oct 7, 2013 at 10:35 AM, Dan Haywood <dan@haywood-associates.co.uk
> > wrote:
>
>> Hi Martin, Michael...
>> I've been keeping the master branch up to date of the bootstrap3 fork of
>> Isis [1], but I noticed that there haven't been any commits recently on the
>> ISIS-537 branch [2].
>>
>> Questions:
>> * are you currently busy on other stuff? (that's fine if you are), or
>> * are you blocked / do I need to get more involved here?
>>
>> As you can imagine, I'm really keen to see this work progress, so if
>> there's anything I can provide to help ensure ongoing progress, I'd like to
>> do that.
>>
>> Also, given things are currently quiet on that branch, would now be a
>> good time for me to do a rebase of ISIS-537 onto master?
>>
>> Cheers
>> Dan
>>
>> [1] https://github.com/l0rdn1kk0n/isis
>> [2] https://github.com/l0rdn1kk0n/isis/commits/ISIS-537
>>
>>
>> On 18 September 2013 13:22, Dan Haywood <da...@haywood-associates.co.uk>wrote:
>>
>>>
>>>
>>> On 18 September 2013 13:13, Martin Grigorov <mg...@apache.org>wrote:
>>>
>>>> On Wed, Sep 18, 2013 at 1:28 PM, Martin Grigorov <mgrigorov@apache.org
>>>> >wrote:
>>>>
>>>> > I was able to run quickstart_wicket_restful_jdo webapp successfully.
>>>> >
>>>> > I see Jetty 6.x is used. I'll update it to 8.x.
>>>> >
>>>>
>>>> I've updated it to Jetty 7.6.13.v20130916 because I've noticed that
>>>> there
>>>> are dependencies to geronimo-servlet-2.5 and jsp-2.1.
>>>> Jetty 8.x requires Servlet API 3.x and maybe there are ISIS users with
>>>> older web servers.
>>>>
>>>
>>> given how young Isis is, that's probably unlikely. But I agree there's
>>> no need to go all the way to Servlet API 3.x at this time.
>>>
>>>
>>>
>>>>
>>>> Why there is a dependency to JSP-2.1 ? I hope ISIS doesn't use JSPs.
>>>>
>>>>
>>> It doesn't. Or rather, it shouldn't. Or rather, the Wicket viewer
>>> doesn't. Would be curious to see why that's added. If you can't remove it
>>> easily, I'll help.
>>>
>>>
>>>
>>>>
>>>> > Additionally I'll add Start.java (as in Wicket's quickstart) because
>>>> it
>>>> > allows to develop/debug much faster. Especially when you use DCEVM (
>>>> >
>>>> http://blog.jetbrains.com/idea/2013/07/get-true-hot-swap-in-java-with-dcevm-and-intellij-idea/
>>>> > ).
>>>> >
>>>>
>>>
>>> ok
>>>
>>>
>>>> > At the moment ISIS-537 branch build fails with some issue related to
>>>> > having several versions of ANTLR. We will have to fix it.
>>>>
>>>
>>> this might be an interaction with JDO/DN; have seen something related to
>>> this before.
>>>
>>>
>>>
>>>> >
>>>> > Also we (me and Michael) prefer to use Twitter Bootstrap 3, so we will
>>>> > have to use Wicket Bootstrap 0.8.5-SNAPSHOT<
>>>> https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/bootstrap3> build
>>>> > from 'bootstrap3' branch. At the moment these snapshots are not
>>>> deployed
>>>> > anywhere so every developer will have to clone Wicket Bootstrap
>>>> project
>>>> > locally and install it (as simple as "mvn clean install")
>>>> >
>>>>
>>>
>>> ok
>>>
>>>
>>>
>>>>
>>>> Twitter Bootstrap 3 doesn't support IE8. Is that a problem for ISIS ?
>>>>
>>>
>>> Nope, that's fine.
>>>
>>> Cheers
>>> Dan
>>>
>>>
>>>
>>>
>>>
>>>
>>
>
Re: [jira] [Created] (ISIS-537) Convert Wicket viewer to use
Bootstrap, so that it can be themed.
Posted by Martin Grigorov <mg...@apache.org>.
Hi Dan,
I'll work on this task this week again.
On Mon, Oct 7, 2013 at 10:35 AM, Dan Haywood
<da...@haywood-associates.co.uk>wrote:
> Hi Martin, Michael...
> I've been keeping the master branch up to date of the bootstrap3 fork of
> Isis [1], but I noticed that there haven't been any commits recently on the
> ISIS-537 branch [2].
>
> Questions:
> * are you currently busy on other stuff? (that's fine if you are), or
> * are you blocked / do I need to get more involved here?
>
> As you can imagine, I'm really keen to see this work progress, so if
> there's anything I can provide to help ensure ongoing progress, I'd like to
> do that.
>
> Also, given things are currently quiet on that branch, would now be a good
> time for me to do a rebase of ISIS-537 onto master?
>
> Cheers
> Dan
>
> [1] https://github.com/l0rdn1kk0n/isis
> [2] https://github.com/l0rdn1kk0n/isis/commits/ISIS-537
>
>
> On 18 September 2013 13:22, Dan Haywood <da...@haywood-associates.co.uk>wrote:
>
>>
>>
>> On 18 September 2013 13:13, Martin Grigorov <mg...@apache.org> wrote:
>>
>>> On Wed, Sep 18, 2013 at 1:28 PM, Martin Grigorov <mgrigorov@apache.org
>>> >wrote:
>>>
>>> > I was able to run quickstart_wicket_restful_jdo webapp successfully.
>>> >
>>> > I see Jetty 6.x is used. I'll update it to 8.x.
>>> >
>>>
>>> I've updated it to Jetty 7.6.13.v20130916 because I've noticed that there
>>> are dependencies to geronimo-servlet-2.5 and jsp-2.1.
>>> Jetty 8.x requires Servlet API 3.x and maybe there are ISIS users with
>>> older web servers.
>>>
>>
>> given how young Isis is, that's probably unlikely. But I agree there's
>> no need to go all the way to Servlet API 3.x at this time.
>>
>>
>>
>>>
>>> Why there is a dependency to JSP-2.1 ? I hope ISIS doesn't use JSPs.
>>>
>>>
>> It doesn't. Or rather, it shouldn't. Or rather, the Wicket viewer
>> doesn't. Would be curious to see why that's added. If you can't remove it
>> easily, I'll help.
>>
>>
>>
>>>
>>> > Additionally I'll add Start.java (as in Wicket's quickstart) because it
>>> > allows to develop/debug much faster. Especially when you use DCEVM (
>>> >
>>> http://blog.jetbrains.com/idea/2013/07/get-true-hot-swap-in-java-with-dcevm-and-intellij-idea/
>>> > ).
>>> >
>>>
>>
>> ok
>>
>>
>>> > At the moment ISIS-537 branch build fails with some issue related to
>>> > having several versions of ANTLR. We will have to fix it.
>>>
>>
>> this might be an interaction with JDO/DN; have seen something related to
>> this before.
>>
>>
>>
>>> >
>>> > Also we (me and Michael) prefer to use Twitter Bootstrap 3, so we will
>>> > have to use Wicket Bootstrap 0.8.5-SNAPSHOT<
>>> https://github.com/l0rdn1kk0n/wicket-bootstrap/tree/bootstrap3> build
>>> > from 'bootstrap3' branch. At the moment these snapshots are not
>>> deployed
>>> > anywhere so every developer will have to clone Wicket Bootstrap project
>>> > locally and install it (as simple as "mvn clean install")
>>> >
>>>
>>
>> ok
>>
>>
>>
>>>
>>> Twitter Bootstrap 3 doesn't support IE8. Is that a problem for ISIS ?
>>>
>>
>> Nope, that's fine.
>>
>> Cheers
>> Dan
>>
>>
>>
>>
>>
>>
>