You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/15 08:04:05 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
sdedic opened a new pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762
See [NETBEANS-5353](https://issues.apache.org/jira/browse/NETBEANS-5353) description; this PR attempts to use gradle's up-to-date checks so unnecessary compilations are avoided during test runs/debugs.
@lkishalmi please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-780398932
BTW - you were very quick ! with the review. In the meantime, I've discovered a negative effect of this PR: the project customizer has a two-state checkbox, which may lead to a temporarily-trusted project becoming permanently trusted after using project customizer.
I'll try to prepare another PR that makes that checkbox tri-state, the indeterminate state for a situation like "the trust is not permanent, but the buildscript is trusted somehow". The user then may leave it asi it is (no change), turn the trust to permanent, or indicate that trust should be revoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic removed a comment on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic removed a comment on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-780398932
BTW - you were very quick ! with the review. In the meantime, I've discovered a negative effect of this PR: the project customizer has a two-state checkbox, which may lead to a temporarily-trusted project becoming permanently trusted after using project customizer.
I'll try to prepare another PR that makes that checkbox tri-state, the indeterminate state for a situation like "the trust is not permanent, but the buildscript is trusted somehow". The user then may leave it asi it is (no change), turn the trust to permanent, or indicate that trust should be revoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-780398932
BTW - you were very quick ! with the review. In the meantime, I've discovered one situation my patch affects adversely - the project customizer has a two-state checkbox, which may lead to a temporarily-trusted project becoming permanently trusted after using project customizer.
I'll try to prepare another PR that makes that checkbox tri-state, the indeterminate state for a situation like "the trust is not permanent, but the buildscript is trusted somehow". The user then may leave it asi it is (no change), turn the trust to permanent, or indicate that trust should be revoked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-780382699
> FYI. We do not use the output files from tests to display the results, but rather listening Gradle's test progress events.
> Also further down the road I'd like to use the dedicated test executor functionality from Gradle, but maybe i won't get that far in this year...
I admin I don't know gradle :) so maybe I guessed wrong: But the docs seemed to suggest that `cleanTest` purges results (outputs) of `test` task from gradle whatever storage, which subsequently leads to reexecution of `test` task (since gradle-cached outputs are gone). This seemed to be the case from early Gradle versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-780382699
> FYI. We do not use the output files from tests to display the results, but rather listening Gradle's test progress events.
> Also further down the road I'd like to use the dedicated test executor functionality from Gradle, but maybe i won't get that far in this year...
I admit I don't know gradle :) so maybe I guessed wrong: But the docs seemed to suggest that `cleanTest` purges results (outputs) of `test` task from gradle whatever storage, which subsequently leads to reexecution of `test` task (since gradle-cached outputs are gone). This seemed to be the case from early Gradle versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-779964768
FYI. We do not use the output files from tests to display the results, but rather listening Gradle's test progress events.
Also further down the road I'd like to use the dedicated test executor functionality from Gradle, but maybe i won't get that far in this year...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-779756805
@lkishalmi also not sure the **clean**_TaskName_ support is documented in Gradle 5.0, so assuming Test task has well-defined outputs (should have, for the results caching to work), **cleanTest** must have worked from that time as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic edited a comment on pull request #2762: [NETBEANS-5353] Use cleanTest instead of rerun-tasks to force test to run
Posted by GitBox <gi...@apache.org>.
sdedic edited a comment on pull request #2762:
URL: https://github.com/apache/netbeans/pull/2762#issuecomment-779756805
@lkishalmi also not sure. The **clean**_TaskName_ pattern support is documented in Gradle 5.0, so assuming Test task has well-defined outputs (should have, for the results caching to work), **cleanTest** must have worked from that time as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists