You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/14 11:16:48 UTC
[GitHub] [superset] NikolayZakharevich opened a new issue, #22416: Feature Request: Add last business day option to time range filter
NikolayZakharevich opened a new issue, #22416:
URL: https://github.com/apache/superset/issues/22416
Hi all, I would like to reopen feature request #13261
**Is your feature request related to a problem? Please describe.**
I am working on a dataset that does not have data for weekends too. Currently, the time range filters supported are based on the calendar irrespective of the presence of data. If I search on a Monday using the last day filter then no results were returned, as expected. The difference from #13261 is that I want to get not only the last business day for Monday but also for all the rest days of the week.
**Describe the solution you'd like**
It would be great if there was an option to filter based on the availability of data or the last business day. The option should return:
- on Monday: `Friday <= col <= Friday`
- on Tuesday: `Monday <= col <= Monday`
- on Wednesday: `Tuesday <= col <= Tuesday`
- on Thursday: `Wednesday <= col <= Wednesday`
- on Friday: `Thursday <= col <= Thursday`
- on Saturday: `Friday <= col <= Friday`
- on Sunday: `Friday <= col <= Friday`
This behaviour is originally described in https://github.com/apache/superset/issues/13261#issuecomment-1321736535
**Describe alternatives you've considered**
I tried to use Advanced date functions as suggested by @ktmud in https://github.com/apache/superset/issues/13261#issuecomment-782975758
```python
dateadd(datetrunc(datetime('today'), week), 5, day)
```
but it works only on Mondays
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kamalkeshavani-aiinside commented on issue #22416: Feature Request: Add last business day option to time range filter
Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside commented on issue #22416:
URL: https://github.com/apache/superset/issues/22416#issuecomment-1352789539
Feature requests are now made through '[Discussions](https://github.com/apache/superset/discussions)', please close this issue and start a thread in discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NikolayZakharevich closed issue #22416: Feature Request: Add last business day option to time range filter
Posted by GitBox <gi...@apache.org>.
NikolayZakharevich closed issue #22416: Feature Request: Add last business day option to time range filter
URL: https://github.com/apache/superset/issues/22416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org