You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/08 09:30:12 UTC
[GitHub] [ozone] qizhu-lucas opened a new pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
qizhu-lucas opened a new pull request #1674:
URL: https://github.com/apache/ozone/pull/1674
## What changes were proposed in this pull request?
Now the OM HA not support suggested Leader, we should support it.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4561
## How was this patch tested?
Later will add unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #1674:
URL: https://github.com/apache/ozone/pull/1674#issuecomment-749962137
@qizhu-lucas , thanks for this improvement. I have following general questions,
1. Is Ratis Leader hint supported in ratis now?
2. If Ratis Leader hint is supported, what's the use case that "ozone.om.ratis.suggested.leader.enable" should be set as false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] qizhu-lucas commented on pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
qizhu-lucas commented on pull request #1674:
URL: https://github.com/apache/ozone/pull/1674#issuecomment-750726276
@ChenSammi
1. Ratis Leader suggested, supported in ratis .
2. I just added false option for test, if we need roll back to original retry OMs based.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on pull request #1674:
URL: https://github.com/apache/ozone/pull/1674#issuecomment-776903687
We had previously removed failover to suggested leader because the nodeId is guaranteed consistency across servers and clients. For example, in server `nodeId1` could point to `OM1` and in client `nodeId1` could be pointing to `OM2`. In this scenario, when the client is told to failover to `nodeId1`, it will keep retrying the request on `OM2` and never reach the actual leader `OM1`.
So instead of using the nodeId to failover, I think we should utilize the OM address to decide which node to failover to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] commented on pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1674:
URL: https://github.com/apache/ozone/pull/1674#issuecomment-804498440
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] closed pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1674:
URL: https://github.com/apache/ozone/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1674: HDDS-4561: We should support suggested Ratis Server Leader in OM HA.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1674:
URL: https://github.com/apache/ozone/pull/1674#issuecomment-787872590
/pending "instead of using the nodeId to failover, I think we should utilize the OM address to decide which node to failover to"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org