[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #9030: [IOTDB-5510] Block and wait to create timeseries when releasing memory

["MarcosZyk (via GitHub)" <gi...@apache.org>]

MarcosZyk commented on code in PR #9030:
URL: https://github.com/apache/iotdb/pull/9030#discussion_r1101048974


##########
server/src/main/java/org/apache/iotdb/db/metadata/schemaregion/SchemaRegionSchemaFileImpl.java:
##########
@@ -520,8 +521,11 @@ public void recoverTimeseries(ICreateTimeSeriesPlan plan, long offset) throws Me
   @SuppressWarnings("squid:S3776") // Suppress high Cognitive Complexity warning
   public void createTimeseries(ICreateTimeSeriesPlan plan, long offset) throws MetadataException {
     if (!memoryStatistics.isAllowToCreateNewSeries()) {
-      logger.error("Series overflow when creating: [{}]", plan.getPath().getFullPath());
-      throw new SeriesOverflowException();
+      CacheMemoryManager.getInstance().waitIfReleasing();
+      if (!memoryStatistics.isAllowToCreateNewSeries()) {
+        logger.error("Series overflow when creating: [{}]", plan.getPath().getFullPath());

Review Comment:
   change log level to warn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org