You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/11/09 17:27:38 UTC
[GitHub] [commons-io] wodencafe commented on a change in pull request #297: IO-552: Honor tilde as a valid character for file and directory names
wodencafe commented on a change in pull request #297:
URL: https://github.com/apache/commons-io/pull/297#discussion_r745848559
##########
File path: src/main/java/org/apache/commons/io/FilenameUtils.java
##########
@@ -201,7 +201,7 @@ public static String concat(final String basePath, final String fullFileNameToAd
if (prefix < 0) {
return null;
}
- if (prefix > 0) {
+ if (prefix > 0 && !fullFileNameToAdd.isEmpty() && '~' != (fullFileNameToAdd.charAt(0))) {
Review comment:
@kinow @garydgregory Thank you for the feedback, I will test out the simplified change tonight and update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org