You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/19 01:17:52 UTC
Review Request 42478: Added missing `json` function for
`ContainerStatus`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42478/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-4238
https://issues.apache.org/jira/browse/MESOS-4238
Repository: mesos
Description
-------
This is needed to correctly invoke the `json` function for `NetworkInfo`.
Without this, `write->field("container_status", status.container_status())` uses the generic `json` function for protobuf messages.
Diffs
-----
src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752
Diff: https://reviews.apache.org/r/42478/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 42478: Added missing `json` function for
`ContainerStatus`.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42478/#review115099
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 19, 2016, 12:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42478/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 12:17 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-4238
> https://issues.apache.org/jira/browse/MESOS-4238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is needed to correctly invoke the `json` function for `NetworkInfo`.
> Without this, `write->field("container_status", status.container_status())` uses the generic `json` function for protobuf messages.
>
>
> Diffs
> -----
>
> src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752
>
> Diff: https://reviews.apache.org/r/42478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 42478: Added missing `json` function for
`ContainerStatus`.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42478/#review115098
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42478]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 19, 2016, 12:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42478/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 12:17 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-4238
> https://issues.apache.org/jira/browse/MESOS-4238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is needed to correctly invoke the `json` function for `NetworkInfo`.
> Without this, `write->field("container_status", status.container_status())` uses the generic `json` function for protobuf messages.
>
>
> Diffs
> -----
>
> src/common/http.cpp 6d8809137602089d77ba7353d285af8de070c752
>
> Diff: https://reviews.apache.org/r/42478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>