You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/05/03 02:23:32 UTC

Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 3, 2018, 2:23 a.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6358ff3002 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3141a7e981 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java b25bb1de49 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 


Diff: https://reviews.apache.org/r/66862/diff/2/

Changes: https://reviews.apache.org/r/66862/diff/1-2/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 15, 2018, 9:34 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0a997a1569 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java de61d717fc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 63fe8adc8b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 75fa09de8e 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3d965c0515 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java b3e76b6259 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 80f77b9f0c 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java 3e2784ba2d 
  ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java a88a570c52 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
  ql/src/test/results/clientpositive/llap/mm_conversions.q.out 4754710291 


Diff: https://reviews.apache.org/r/66862/diff/7/

Changes: https://reviews.apache.org/r/66862/diff/6-7/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 11, 2018, 11:37 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 44b9eb2824 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 63fe8adc8b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 75fa09de8e 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 3d965c0515 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java b61a945d94 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 80f77b9f0c 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java 3e2784ba2d 
  ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java a88a570c52 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
  ql/src/test/results/clientpositive/llap/mm_conversions.q.out 4754710291 


Diff: https://reviews.apache.org/r/66862/diff/6/

Changes: https://reviews.apache.org/r/66862/diff/5-6/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 10, 2018, 7:13 p.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cc490afc77 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java abde9f786f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 75fa09de8e 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 655d10b643 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java b61a945d94 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 80f77b9f0c 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java 3e2784ba2d 
  ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java a88a570c52 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
  ql/src/test/results/clientpositive/llap/mm_conversions.q.out 4754710291 


Diff: https://reviews.apache.org/r/66862/diff/5/

Changes: https://reviews.apache.org/r/66862/diff/4-5/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 9, 2018, 2:11 a.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 88a7cfc70e 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java abde9f786f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 75fa09de8e 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 655d10b643 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java b61a945d94 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java 80f77b9f0c 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java 3e2784ba2d 
  ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java a88a570c52 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
  ql/src/test/results/clientpositive/llap/mm_conversions.q.out 4754710291 


Diff: https://reviews.apache.org/r/66862/diff/4/

Changes: https://reviews.apache.org/r/66862/diff/3-4/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/
-----------------------------------------------------------

(Updated May 8, 2018, 1:10 a.m.)


Review request for hive and Thejas Nair.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 23a9c74a60 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3141a7e981 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
  ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 58f0480059 
  ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 655d10b643 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/io/FileOperations.java b61a945d94 
  ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
  ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
  ql/src/test/results/clientpositive/llap/mm_conversions.q.out 4754710291 


Diff: https://reviews.apache.org/r/66862/diff/3/

Changes: https://reviews.apache.org/r/66862/diff/2-3/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66862/#review202395
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
Lines 553 (patched)
<https://reviews.apache.org/r/66862/#comment284304>

    'fi' - comment chopped off?



ql/src/test/queries/clientpositive/mm_conversions.q
Lines 28 (patched)
<https://reviews.apache.org/r/66862/#comment284204>

    No golden file changes for this test in this patch.


- Jason Dere


On May 3, 2018, 2:23 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66862/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 2:23 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6358ff3002 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 7e17d5d888 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3141a7e981 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 969c591917 
>   ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java b25bb1de49 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6 
>   ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java b698c84080 
>   ql/src/test/queries/clientpositive/mm_conversions.q 55565a9428 
> 
> 
> Diff: https://reviews.apache.org/r/66862/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>