You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/30 09:49:30 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28004: Fix failing test case for db clean in newer sqlalchemy
potiuk opened a new pull request, #28004:
URL: https://github.com/apache/airflow/pull/28004
Fixing of ambiguity of treating "*" in SQLAlchemy 4.1.42 made our tests to fail, because they were trying to execute the query from aliased table as a standalone queryi for verificaiton, where in "reality" the same query would be executed as part of "CREATE AS" statement.
The tests started to fail with the new SQLAlchemy and the fix was to change our tests to also run "CREATE AS" statement and count number of rows in the created temporary table.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28004: Fix failing test case for db clean in newer sqlalchemy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28004:
URL: https://github.com/apache/airflow/pull/28004#issuecomment-1331960054
Some of the failing tests passed. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28004: Fix failing test case for db clean in newer sqlalchemy
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28004:
URL: https://github.com/apache/airflow/pull/28004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28004: Fix failing test case for db clean in newer sqlalchemy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28004:
URL: https://github.com/apache/airflow/pull/28004#issuecomment-1331933739
> Don't need the log though?
Yep. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org