[GitHub] rdhabalia commented on a change in pull request #1733: allow custom sources and sink to run on connector framework

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #1733:  allow custom sources and sink to run on connector framework
URL: https://github.com/apache/incubator-pulsar/pull/1733#discussion_r186206304
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -57,20 +57,22 @@ message SourceSpec {
     string className = 1;
     // map in json format
     string configs = 2;
+    string typeClassName = 3;
 
     // configs used only when source feeds into functions
-    SubscriptionType subscriptionType = 3;
-    map<string,string> topicsToSerDeClassName = 4;
+    SubscriptionType subscriptionType = 4;
 
 Review comment:
   it won't be compatible with previous version. we should add new fields with new sequence id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services