You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "chengyouling (via GitHub)" <gi...@apache.org> on 2023/12/13 08:04:12 UTC
[PR] [#4132] router support set fallback route as downgrading routing strategy [servicecomb-java-chassis]
chengyouling opened a new pull request, #4133:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4133
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4132] router support set fallback route as downgrading routing strategy [servicecomb-java-chassis]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4133:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4133#issuecomment-1855018861
## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `11 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`01e4595`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/01e459575a2c7bab82b31d8e5ba67be81534d29b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 74.15% compared to head [(`4feb815`)](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 74.26%.
> Report is 4 commits behind head on 2.8.x.
> :exclamation: Current head 4feb815 differs from pull request most recent head 9e822bf. Consider uploading reports for the commit 9e822bf to get more accurate results
| [Files](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...b/router/distribute/AbstractRouterDistributor.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcm91dGVyL2Rpc3RyaWJ1dGUvQWJzdHJhY3RSb3V0ZXJEaXN0cmlidXRvci5qYXZh) | 88.46% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rvicecomb/core/provider/consumer/InvokerUtils.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9wcm92aWRlci9jb25zdW1lci9JbnZva2VyVXRpbHMuamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ervicecomb/tracing/zipkin/ZipkinTracingFilter.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luVHJhY2luZ0ZpbHRlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rvicecomb/tracing/zipkin/ZipkinTracingHandler.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luVHJhY2luZ0hhbmRsZXIuamF2YQ==) | 75.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...b/tracing/zipkin/ZipkinConsumerTracingHandler.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luQ29uc3VtZXJUcmFjaW5nSGFuZGxlci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...b/tracing/zipkin/ZipkinProviderTracingHandler.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aGFuZGxlcnMvaGFuZGxlci10cmFjaW5nLXppcGtpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhY2luZy96aXBraW4vWmlwa2luUHJvdmlkZXJUcmFjaW5nSGFuZGxlci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.8.x #4133 +/- ##
============================================
+ Coverage 74.15% 74.26% +0.11%
+ Complexity 707 706 -1
============================================
Files 1594 1594
Lines 40146 40177 +31
Branches 3659 3665 +6
============================================
+ Hits 29769 29839 +70
+ Misses 8889 8850 -39
Partials 1488 1488
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/4133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4132] router support set fallback route as downgrading routing strategy [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4133:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org