You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/05 16:19:11 UTC
[GitHub] [beam] sonam-vend opened a new pull request #13669: Enabled strict dependency on Twister2
sonam-vend opened a new pull request #13669:
URL: https://github.com/apache/beam/pull/13669
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tysonjh commented on a change in pull request #13669: [BEAM-10961] Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
tysonjh commented on a change in pull request #13669:
URL: https://github.com/apache/beam/pull/13669#discussion_r558474683
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
This is a lower version than `$checkerframework_version`, is there a reason?
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
Review comment:
Move this up with the other `library.` definitions.
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
+ compile "org.twister2:comms-api-java:0.6.0"
Review comment:
Use `$twister2_version` throughout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #13669: [BEAM-10961] Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #13669:
URL: https://github.com/apache/beam/pull/13669#discussion_r558486474
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
This should be removed now that #13690 is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib merged pull request #13669: [BEAM-10961] Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
ibzib merged pull request #13669:
URL: https://github.com/apache/beam/pull/13669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on a change in pull request #13669: [BEAM-10961] Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on a change in pull request #13669:
URL: https://github.com/apache/beam/pull/13669#discussion_r558566091
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
Review comment:
done, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #13669: Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #13669:
URL: https://github.com/apache/beam/pull/13669#issuecomment-756192343
R: @ibzib , @aaltay can you please review or add reviewers who can review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] sonam-vend commented on pull request #13669: [BEAM-10961] Enabled strict dependency on Twister2
Posted by GitBox <gi...@apache.org>.
sonam-vend commented on pull request #13669:
URL: https://github.com/apache/beam/pull/13669#issuecomment-760545033
R: @tysonjh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org