[jira] [Commented] (PHOENIX-5565) Unify index update structures in IndexRegionObserver and IndexCommitter

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971253#comment-16971253 ] 

Hadoop QA commented on PHOENIX-5565:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12985472/PHOENIX-5565.master.001.patch
  against master branch at commit 70baf4c6805eb46420dd1fbaf71a093ab7d84a8b.
  ATTACHMENT ID: 12985472

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +      private ListMultimap<HTableInterfaceReference, Pair<Mutation, byte[]>> intermediatePostIndexUpdates;
+                                       ListMultimap<HTableInterfaceReference, Pair<Mutation, byte[]>> indexUpdates) {
+      byte[] tableName = c.getEnvironment().getRegion().getTableDescriptor().getTableName().getName();
+      List<Pair<Mutation, byte[]>> localIndexUpdates = indexUpdates.removeAll(hTableInterfaceReference);
+          miniBatchOp.addOperationsFromCP(0, localUpdates.toArray(new Mutation[localUpdates.size()]));
+          context.intermediatePostIndexUpdates = ArrayListMultimap.<HTableInterfaceReference, Pair<Mutation, byte[]>>create();
+          this.builder.getIndexUpdates(context.intermediatePostIndexUpdates, miniBatchOp, mutations, indexMetaData);
+                      new HTableInterfaceReference(new ImmutableBytesPtr(indexMaintainer.getIndexTableName()));
+          // Add the table rows in the mini batch to the collection of pending rows. This will be used to detect
+                      new HTableInterfaceReference(new ImmutableBytesPtr(indexMaintainer.getIndexTableName()));

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3110//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3110//console

This message is automatically generated.

> Unify index update structures in IndexRegionObserver and IndexCommitter
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-5565
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5565
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.1.0
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>         Attachments: PHOENIX-5565.master.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The index updates are represented by a Collection<Pair<Mutation, byte[]>> where the byte[] member of the pair is the name of the index table. However, this map is then translated to a Multimap<HTableInterfaceReference, Mutation> when it is passed to an IndexCommitter. The code in IndexRegionObserver gets simplified and becomes more efficient in cpu utilization if IndexRegionObserver also uses a Multimap<HTableInterfaceReference, Mutation> structure to represent index updates. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)