[GitHub] [iceberg] dramaticlly commented on a diff in pull request #5039: Print db and table name while acquiring hive meta-store lock

[GitBox <gi...@apache.org>]

dramaticlly commented on code in PR #5039:
URL: https://github.com/apache/iceberg/pull/5039#discussion_r897412042


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -512,6 +513,7 @@ long acquireLock() throws UnknownHostException, TException, InterruptedException
     LockResponse lockResponse = metaClients.run(client -> client.lock(lockRequest));
     AtomicReference<LockState> state = new AtomicReference<>(lockResponse.getState());
     long lockId = lockResponse.getLockid();
+    Pair<Long, String> lockDetails = Pair.of(lockId, String.format("%s.%s", database, tableName));

Review Comment:
   nit: can make it final



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org