[GitHub] [druid] cryptoe commented on a diff in pull request #13670: msq path to emit unparseable exceptions

[GitBox <gi...@apache.org>]

cryptoe commented on code in PR #13670:
URL: https://github.com/apache/druid/pull/13670#discussion_r1070193291


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/error/MSQWarningReportLimiterPublisher.java:
##########
@@ -108,6 +115,12 @@ public void publishException(int stageNumber, Throwable e)
         return;
       }
     }
+    if (CannotParseExternalDataFault.CODE.equals(errorCode)) {

Review Comment:
   This is what I would do: 
   Rename `MSQWarningReportPublisher` to `ExceptionPublisher`.
   
   
   Create a new CompositeExceptionPublisher.
   
   One implementation can be of a FilteredEmitterExceptionPublisher where in the constructor you take the error code. 
   
   It would be cool to avoid This call
   :MSQErrorReport msqFault = MSQErrorReport.fromException(workerId, host, stageNumber, e);
   



##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/FrameProcessorFactory.java:
##########
@@ -30,6 +30,7 @@
 import javax.annotation.Nullable;
 import java.io.IOException;
 import java.util.List;
+import java.util.function.BiConsumer;

Review Comment:
   nit: looks like this change is not required



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org