[GitHub] [druid] adarshsanjeev commented on pull request #14257: Configure maxBytesPerWorker directly instead of using StageDefinition

["adarshsanjeev (via GitHub)" <gi...@apache.org>]

adarshsanjeev commented on PR #14257:
URL: https://github.com/apache/druid/pull/14257#issuecomment-1546664257

   Thanks for the review @LakshSingla! I have added some tests for static and dynamic slicing which should cover these cases.
   For the test files, the 3 files I created are made by splitting the single wikipedia-sampled file. This lets us assert for the same expected results, which I thought was neat. Since these files are pretty small, I thought this was fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org