You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/22 13:43:11 UTC

[GitHub] [iceberg] Fokko opened a new pull request, #5610: Spark: Set the current schema id when rolling back a snapshot

Fokko opened a new pull request, #5610:
URL: https://github.com/apache/iceberg/pull/5610

   Resolves #5591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko closed pull request #5610: Spark: Set the current schema id when rolling back a snapshot

Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #5610: Spark: Set the current schema id when rolling back a snapshot
URL: https://github.com/apache/iceberg/pull/5610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko commented on pull request #5610: Spark: Set the current schema id when rolling back a snapshot

Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #5610:
URL: https://github.com/apache/iceberg/pull/5610#issuecomment-1222391529

   @rdblue can you take a peek at this? More background information is at the issue: https://github.com/apache/iceberg/issues/5591
   
   My only concern is that we should only set the current-schema-id when we're on the main branch. But in that case, we might also want to move this to `setBranchSnapshotInternal`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko commented on pull request #5610: Spark: Set the current schema id when rolling back a snapshot

Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #5610:
URL: https://github.com/apache/iceberg/pull/5610#issuecomment-1225746117

   I'll close this now and create a new PR that explains the behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org