You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/09/15 22:53:12 UTC

svn commit: r815479 [1/3] - in /ofbiz/trunk/applications/workeffort: config/WorkEffortEntityLabels.xml config/WorkEffortUiLabels.xml widget/CalendarForms.xml widget/CalendarScreens.xml

Author: jleroux
Date: Tue Sep 15 20:53:11 2009
New Revision: 815479

URL: http://svn.apache.org/viewvc?rev=815479&view=rev
Log:
A patch from Erwan de FERRIERES "improvement on the calendar screen" (https://issues.apache.org/jira/browse/OFBIZ-2941) - OFBIZ-2941

This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen. 

Modified:
    ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml
    ofbiz/trunk/applications/workeffort/config/WorkEffortUiLabels.xml
    ofbiz/trunk/applications/workeffort/widget/CalendarForms.xml
    ofbiz/trunk/applications/workeffort/widget/CalendarScreens.xml

Modified: ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml?rev=815479&r1=815478&r2=815479&view=diff
==============================================================================
--- ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml (original)
+++ ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml Tue Sep 15 20:53:11 2009
@@ -287,7 +287,7 @@
     </property>
     <property key="WorkEffortType.description.BUSINESS_TRAVEL">
         <value xml:lang="en">Business Travel</value>
-        <value xml:lang="en">Voyage professionnel</value>
+        <value xml:lang="fr">Voyage professionnel</value>
         <value xml:lang="it">Viaggio di lavoro</value>
         <value xml:lang="zh">商务旅行</value>
     </property>

Re: svn commit: r815479 [1/3] - in /ofbiz/trunk/applications/workeffort: config/WorkEffortEntityLabels.xml config/WorkEffortUiLabels.xml widget/CalendarForms.xml widget/CalendarScreens.xml

Posted by Erwan de FERRIERES <er...@nereide.biz>.
Hi Hans,

there was a missing container in the screen, I'm sending the patch to 
correct it.

Le 16/09/2009 03:21, Hans Bakker a écrit :
> Dear Jacques,
>
> I have big problems with this change. go to the flat-gray scheme and
> look at he calendar in firefox 3. These containers were there for a
> reason: to have a proper display, and now it is looking pretty bad.
>
> To reproduce:
>
> go to myportal ->  calendar -->   add an event.
../..
-- 
- Erwan -

Re: svn commit: r815479 [1/3] - in /ofbiz/trunk/applications/workeffort: config/WorkEffortEntityLabels.xml config/WorkEffortUiLabels.xml widget/CalendarForms.xml widget/CalendarScreens.xml

Posted by Hans Bakker <ma...@antwebsystems.com>.
Dear Jacques,

I have big problems with this change. go to the flat-gray scheme and
look at he calendar in firefox 3. These containers were there for a
reason: to have a proper display, and now it is looking pretty bad.

To reproduce:

go to myportal -> calendar -->  add an event.

Then the right hand side is all blue and the paging buttons all in the
wrong place.....

further adding an event was all in one single screenlet to indicate the
information was belonging to the same event: info and participants.

So please, i liked the old organization much better and would like his
reversed.

Regards,
Hans



On Tue, 2009-09-15 at 20:53 +0000, jleroux@apache.org wrote:
> Author: jleroux
> Date: Tue Sep 15 20:53:11 2009
> New Revision: 815479
> 
> URL: http://svn.apache.org/viewvc?rev=815479&view=rev
> Log:
> A patch from Erwan de FERRIERES "improvement on the calendar screen" (https://issues.apache.org/jira/browse/OFBIZ-2941) - OFBIZ-2941
> 
> This is an improvement on the view calendar screen, to use more screenlets and less containers. The hardcoded labels have also been removed.
> The modifications are visible when creating or editing an event listed in the calendar. Boxes are better rendered and have a title bar as the other parts of the screen. 
> 
> Modified:
>     ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml
>     ofbiz/trunk/applications/workeffort/config/WorkEffortUiLabels.xml
>     ofbiz/trunk/applications/workeffort/widget/CalendarForms.xml
>     ofbiz/trunk/applications/workeffort/widget/CalendarScreens.xml
> 
> Modified: ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml?rev=815479&r1=815478&r2=815479&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml (original)
> +++ ofbiz/trunk/applications/workeffort/config/WorkEffortEntityLabels.xml Tue Sep 15 20:53:11 2009
> @@ -287,7 +287,7 @@
>      </property>
>      <property key="WorkEffortType.description.BUSINESS_TRAVEL">
>          <value xml:lang="en">Business Travel</value>
> -        <value xml:lang="en">Voyage professionnel</value>
> +        <value xml:lang="fr">Voyage professionnel</value>
>          <value xml:lang="it">Viaggio di lavoro</value>
>          <value xml:lang="zh">商务旅行</value>
>      </property>
> 
> 
-- 
Antwebsystems.com: Quality OFBiz services for competitive rates