[jira] [Issue Comment Edited] (ZOOKEEPER-1136) NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the twiki

["Mahadev konar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104289#comment-13104289 ] 

Mahadev konar edited comment on ZOOKEEPER-1136 at 9/14/11 6:25 AM:
-------------------------------------------------------------------

The patch looks good to me, but there are changes that werent necessary in the patch, like:

{code}
+            sock.setSoTimeout(leader.self.getTickTime()*leader.self.getInitLimit());
{code}

in LearnerHandler.java and also the ByteBufferOutputStream changes.

We should enumerate the list of changes made in a patch so that its easier for others to reason about the changes.

I will go ahead and commit this for now.


      was (Author: mahadev):
    The patch looks good to me, but there are changes that werent necessary in the patch, like:

{code}
+            sock.setSoTimeout(leader.self.getTickTime()*leader.self.getInitLimit());
{code}

in LearnerHandler.java and also the ByteBufferOutputStream changes.

We should enumerate the list of changes made in a patch so that its consistent with the changes in the patch.

I will go ahead and commit this for now.

  
> NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the twiki
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1136
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1136
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Blocker
>             Fix For: 3.3.4, 3.4.0
>
>         Attachments: ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch
>
>
> the NEW_LEADER message was sent at the beginning of the sync phase in Zab pre1.0, but it must be at the end in Zab 1.0. if the protocol is 1.0 or greater we need to queue rather than send the packet.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira