[jira] [Commented] (OOZIE-3002) address findbugs errors in client lib

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227196#comment-16227196 ] 

Hadoop QA commented on OOZIE-3002:
----------------------------------

Testing JIRA OOZIE-3002

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:red}-1{color} There are [3] new bugs found below threshold in total that must be fixed.
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:red}-1{color} There are [3] new bugs found below threshold in [client] that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): client/findbugs-new.html
. The most important FindBugs errors are:
. At JsonToBean.java:[line 259]: Primitive value is boxed and then immediately unboxed in org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.parseType(Class, Object)
. At JsonToBean.java:[line 259]: Boxed value is unboxed and then immediately reboxed in org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.parseType(Class, Object)
. At JsonToBean.java:[line 259]: Boxed value is unboxed and then immediately reboxed in org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.parseType(Class, Object)
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 2048
.    Tests failed: 8
.    Tests errors: 3

.    The patch failed the following testcases:

.      testImportTablesOverflowBatchSize(org.apache.oozie.tools.TestDBLoadDump)
.      testImportInvalidDataLeavesTablesEmpty(org.apache.oozie.tools.TestDBLoadDump)
.      testImportToNonEmptyTablesCausesPrematureExit(org.apache.oozie.tools.TestDBLoadDump)
.      testImportedDBIsExportedCorrectly(org.apache.oozie.tools.TestDBLoadDump)
.      testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.      testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.      testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.      testPigScript(org.apache.oozie.action.hadoop.TestPigMain)

.    Tests failing with errors:
.      testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
.      testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)
.      testJMXInstrumentation(org.apache.oozie.util.TestMetricsInstrumentation)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/151/

> address findbugs errors in client lib
> -------------------------------------
>
>                 Key: OOZIE-3002
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3002
>             Project: Oozie
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 4.3.0
>         Environment: Java 1.8.0.131
> Maven 3.5.0
> OSX 10.12.5
> commit 18694b616f419ed958230cedb2dc0431a9f9cb5d
>            Reporter: Artem Ervits
>            Assignee: Artem Ervits
>         Attachments: OOZIE-3002-0.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)