[GitHub] [geode] mhansonp commented on a change in pull request #6036: GEODE-8856: Persist gateway-sender state

[GitBox <gi...@apache.org>]

mhansonp commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r585837831



##########
File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderFactoryImpl.java
##########
@@ -271,10 +278,7 @@ public GatewaySender create(String id, int remoteDSId) {
       if (this.cache instanceof GemFireCacheImpl) {
         sender = new ParallelGatewaySenderImpl(cache, statisticsClock, attrs);
         this.cache.addGatewaySender(sender);
-
-        if (!this.attrs.isManualStart()) {
-          sender.start();
-        }
+        bringGatewaySenderToConfiguredState(sender);

Review comment:
       bringGatewaySenderToConfiguredState abandons the manualStartCheck... Why did you make that move here? I kind of expected to see getGatewaySenderDesiredState called.

##########
File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderFactoryImpl.java
##########
@@ -298,9 +302,7 @@ public GatewaySender create(String id, int remoteDSId) {
       if (this.cache instanceof GemFireCacheImpl) {
         sender = new SerialGatewaySenderImpl(cache, statisticsClock, attrs);
         this.cache.addGatewaySender(sender);
-        if (!this.attrs.isManualStart()) {
-          sender.start();
-        }
+        bringGatewaySenderToConfiguredState(sender);

Review comment:
       same as above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org