You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wave-dev@incubator.apache.org by pablojan <gi...@git.apache.org> on 2016/10/23 12:47:41 UTC
[GitHub] incubator-wave pull request #17: Update xerces, gwt and guava dependencies
GitHub user pablojan opened a pull request:
https://github.com/apache/incubator-wave/pull/17
Update xerces, gwt and guava dependencies
This PR fixes gwt building issues. It also update base gwt and guava deps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pablojan/incubator-wave fix-gwt-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-wave/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 1e6046cb8672e7dda8ee3b9ce7e8a71b45c52515
Author: Pablo Ojanguren <pa...@gmail.com>
Date: 2016-10-23T12:44:30Z
Update xerces, gwt and guava dependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave pull request #17: Update xerces, gwt and guava dependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-wave/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by wisebaldone <gi...@git.apache.org>.
Github user wisebaldone commented on the issue:
https://github.com/apache/incubator-wave/pull/17
hmm seems compiling gwt should be added to the ci chain
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava
dependencies
Posted by pa...@gmail.com.
Thanks guys! ;)
El 24 nov. 2016 1:22 p. m., Evan Hughes <eh...@gmail.com> escribió:
increasing the committer member count wouldn't be a bad idea :P
On Thu, 24 Nov 2016 at 22:06 Yuri Z <ve...@gmail.com> wrote:
> By the way, maybe we should add pablo as committer?
>
> On Tue, Nov 1, 2016 at 1:02 PM <pa...@gmail.com> wrote:
>
> > Also GWT 2.8 has been released xD
> >
> > googlewebtoolkit.blogspot.com.es/2016/10/gwt-28-released.html?m=1
> >
> > El 1 nov. 2016 4:55 a. m., wisebaldone <gi...@git.apache.org> escribió:
> >
> > Github user wisebaldone commented on the issue:
> >
> > https://github.com/apache/incubator-wave/pull/17
> >
> > Haha, seems inbetween this passing that guava became a full release
> > aswell.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
> >
>
Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by Evan Hughes <eh...@gmail.com>.
increasing the committer member count wouldn't be a bad idea :P
On Thu, 24 Nov 2016 at 22:06 Yuri Z <ve...@gmail.com> wrote:
> By the way, maybe we should add pablo as committer?
>
> On Tue, Nov 1, 2016 at 1:02 PM <pa...@gmail.com> wrote:
>
> > Also GWT 2.8 has been released xD
> >
> > googlewebtoolkit.blogspot.com.es/2016/10/gwt-28-released.html?m=1
> >
> > El 1 nov. 2016 4:55 a. m., wisebaldone <gi...@git.apache.org> escribió:
> >
> > Github user wisebaldone commented on the issue:
> >
> > https://github.com/apache/incubator-wave/pull/17
> >
> > Haha, seems inbetween this passing that guava became a full release
> > aswell.
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
> >
>
Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by Yuri Z <ve...@gmail.com>.
By the way, maybe we should add pablo as committer?
On Tue, Nov 1, 2016 at 1:02 PM <pa...@gmail.com> wrote:
> Also GWT 2.8 has been released xD
>
> googlewebtoolkit.blogspot.com.es/2016/10/gwt-28-released.html?m=1
>
> El 1 nov. 2016 4:55 a. m., wisebaldone <gi...@git.apache.org> escribió:
>
> Github user wisebaldone commented on the issue:
>
> https://github.com/apache/incubator-wave/pull/17
>
> Haha, seems inbetween this passing that guava became a full release
> aswell.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
>
Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava
dependencies
Posted by pa...@gmail.com.
Also GWT 2.8 has been released xD
googlewebtoolkit.blogspot.com.es/2016/10/gwt-28-released.html?m=1
El 1 nov. 2016 4:55 a. m., wisebaldone <gi...@git.apache.org> escribió:
Github user wisebaldone commented on the issue:
https://github.com/apache/incubator-wave/pull/17
Haha, seems inbetween this passing that guava became a full release aswell.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by wisebaldone <gi...@git.apache.org>.
Github user wisebaldone commented on the issue:
https://github.com/apache/incubator-wave/pull/17
Haha, seems inbetween this passing that guava became a full release aswell.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by wisebaldone <gi...@git.apache.org>.
Github user wisebaldone commented on the issue:
https://github.com/apache/incubator-wave/pull/17
LGTM by inspection, we be pushed on friday/saturday if yuri doesnt get too it first.
Thankyou for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies
Posted by pablojan <gi...@git.apache.org>.
Github user pablojan commented on the issue:
https://github.com/apache/incubator-wave/pull/17
Not sure If you was expecting me to do the merge, I don't have permissions
;)
2016-10-23 19:10 GMT+02:00 Yuri Z. <no...@github.com>:
> *@vega113* approved this pull request.
>
> LGTM
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-wave/pull/17#pullrequestreview-5368192>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEP6D0vqluMjzjhDd5L3BlJz-mRlv7xXks5q25T3gaJpZM4KeH4f>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---