You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "George Timoshenko (JIRA)" <ji...@apache.org> on 2008/02/13 10:36:10 UTC

[jira] Created: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimisations

[drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimisations
----------------------------------------------------------------------------------

                 Key: HARMONY-5500
                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
             Project: Harmony
          Issue Type: Improvement
          Components: DRLVM
            Reporter: George Timoshenko
            Priority: Minor


This time IRBuilder lives only during translation.
All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.

HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.

It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations

Posted by "George Timoshenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Timoshenko updated HARMONY-5500:
---------------------------------------

    Summary: [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations  (was: [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimisations)

> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations

Posted by "George Timoshenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586246#action_12586246 ] 

George Timoshenko commented on HARMONY-5500:
--------------------------------------------

Konstantin,

Egor was wrong in that post.
The issue 5500 has nothing similar with removing simplifier and CSE funtionality from IRBuilder!

IMO these IRBuilder features MUST be kept available even when IRBuilder becomes independent from translator.
By "independence" from translator I mean IRBuilder will live during all HLO stages.
Each HLO pass can configure it (set flags, turn ON or OFF simplification and CSE hashing etc.) and use for HIR instruction creation.
CSE hash must be cleaned when a pass finishes its usage.


> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations

Posted by "George Timoshenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586637#action_12586637 ] 

George Timoshenko commented on HARMONY-5500:
--------------------------------------------

Yes, you are right.

For your IRBuilder cleanup you need a separate JIRA issue and probably voting process.

> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimisations

Posted by "Egor Pasko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568485#action_12568485 ] 

Egor Pasko commented on HARMONY-5500:
-------------------------------------

Good idea, thanks, George

> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimisations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations

Posted by "Konstantin Okonechnikov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586492#action_12586492 ] 

Konstantin Okonechnikov commented on HARMONY-5500:
--------------------------------------------------

George, do I get it right that the only  IRBuilder depedence of the translator, is that the translator creates it; and the problem is that IRBuilder is not available in HLO? So there is no need to modify IrBuilder itself (maybe only correct flag behaviour)?  

> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5500) [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations

Posted by "Konstantin Okonechnikov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586092#action_12586092 ] 

Konstantin Okonechnikov commented on HARMONY-5500:
--------------------------------------------------

Discussion for this issue
       <a href= "http://mail-archives.apache.org/mod_mbox/harmony-dev/200803.mbox/%3c0vqzlst35if.fsf@gmail.com%3e">  harmony-dev mail list </a>

> [drlvm][jit][opt] IRBuilder improvement to make it usable in all HLO optimizations
> ----------------------------------------------------------------------------------
>
>                 Key: HARMONY-5500
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5500
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: George Timoshenko
>            Priority: Minor
>
> This time IRBuilder lives only during translation.
> All HLO optimizations creates necessary instructions "manually". And sometimes it is not very convenient.
> HLOAPIMagic pass is the best example of such inconvenience. A number of methods for generating instructions into HIR are just copy/pasted there from IRBuilder.
> It would be better to make IRBuilder independant from translator and keep it alive during all the HLO so HLOAPIMagic all other passes can use it for instruction creation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.