You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2022/12/02 06:21:39 UTC

[rocketmq] 01/01: Persist consumer offset should not be disabled when auto commit is turned off

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch dev-22
in repository https://gitbox.apache.org/repos/asf/rocketmq.git

commit e249b676eab064d784da375b62a1ac4310049e35
Author: SSpirits <ad...@lv5.moe>
AuthorDate: Fri Nov 25 10:06:31 2022 +0800

    Persist consumer offset should not be disabled when auto commit is turned off
---
 .../rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java    | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
index 498c3e360..a5712008c 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
@@ -1111,10 +1111,6 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner {
 
     @Override
     public void persistConsumerOffset() {
-        // this method will be called by MQInstance schedule task, commit offset depends on autocommit config
-        if (!this.defaultLitePullConsumer.isAutoCommit()) {
-            return;
-        }
         try {
             checkServiceState();
             Set<MessageQueue> mqs = new HashSet<>();