You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/16 19:17:49 UTC

[GitHub] [hadoop] pjfanning commented on pull request #5224: HADOOP-18575: make transformer factory more lenient

pjfanning commented on PR #5224:
URL: https://github.com/apache/hadoop/pull/5224#issuecomment-1355461706

   > needs a test.
   > 
   > if bestEffortSet was made package private then tests could go in to
   > 
   > * verify a known attr is set with result true
   > * unknown attr is swallowed and returned false.
   > 
   > we need this as the xml parsers we probably work with will take the attributes production code generates
   
   added basic test coverage


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org