You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/02 06:49:06 UTC
[jira] [Commented] (HADOOP-10363) Closing of SequenceFile.Reader /
SequenceFile.Writer in DistCh should check against null
[ https://issues.apache.org/jira/browse/HADOOP-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524879#comment-14524879 ]
Hadoop QA commented on HADOOP-10363:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12662725/HADOOP-10363.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6349/console |
This message was automatically generated.
> Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-10363
> URL: https://issues.apache.org/jira/browse/HADOOP-10363
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HADOOP-10363.patch
>
>
> Here is related code:
> {code}
> try {
> for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) {
> ...
> finally {
> in.close();
> }
> {code}
> {code}
> SequenceFile.Writer opWriter = null;
> try {
> opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class,
> FileOperation.class, SequenceFile.CompressionType.NONE);
> ...
> } finally {
> opWriter.close();
> }
> {code}
> If ctor of Reader / Writer throws exception, the close() would be called on null object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)