[GitHub] [hadoop] mukund-thakur commented on pull request #2148: HADOOP-17131 Moving listing to use operation callback

[GitBox <gi...@apache.org>]

mukund-thakur commented on pull request #2148:
URL: https://github.com/apache/hadoop/pull/2148#issuecomment-660136818


   Test failures:
   `[ERROR] Failures: 
   [ERROR]   ITestS3GuardOutOfBandOperations.testRootTombstones:619->Assert.assertNotEquals:161->Assert.failEquals:185->Assert.fail:88 Listing was not supposed to include s3a://mthakur-data/test/testRootTombstones[auth=false]-nonauth0da8099f-ff80-4bf1-87f4-6a1326388907/test.file. Actual: s3a://mthakur-data/test/testRootTombstones[auth=false]-nonauth0da8099f-ff80-4bf1-87f4-6a1326388907/test.file
   [ERROR]   ITestS3GuardOutOfBandOperations.testTombstoneExpiryGuardedDeleteRawCreate:358->Assert.assertNotEquals:161->Assert.failEquals:185->Assert.fail:88 Listing was not supposed to include s3a://mthakur-data/test/TEGDRC-13fba05d-ff3c-4a15-bb96-75942ac8f458/file. Actual: s3a://mthakur-data/test/TEGDRC-13fba05d-ff3c-4a15-bb96-75942ac8f458/file`
   
   The reason test fails is we are mocking the ITtlTimeProvider after the fileSystem is initialised thus not propagating the updated ITtlTimeProvider instance to StoreContext.
   
   One solution I have in my mind is to add one method to fetch the update TtlProvider in OperationCallbacks. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org