[jira] [Commented] (HBASE-17494) Guard against cloning family of all cells if no data need be replicated

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830606#comment-15830606 ] 

Ted Yu commented on HBASE-17494:
--------------------------------

lgtm

> Guard against cloning family of all cells if no data need be replicated
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17494
>                 URL: https://issues.apache.org/jira/browse/HBASE-17494
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ChiaPing Tsai
>            Priority: Trivial
>             Fix For: 1.4.0
>
>         Attachments: HBASE-17494.branch-1.v0.patch
>
>
> The replication is enabled by default, so we try to clone the family of all cells even if there is no replication at all.
> {noformat}
>   family = CellUtil.cloneFamily(cell);
>   // Unexpected, has a tendency to happen in unit tests
>   assert htd.getFamily(family) != null;
>   if (!scopes.containsKey(family)) {
>   int scope = htd.getFamily(family).getScope();
>   if (scope != REPLICATION_SCOPE_LOCAL) {
>   scopes.put(family, scope);
>   }
>   }
> {noformat}
> HBASE-15205 had resolved this issue, but it is committed to master only.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)