You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by "ivila (via GitHub)" <gi...@apache.org> on 2025/09/05 06:54:04 UTC

[I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

ivila opened a new issue, #228:
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228

   Currently, we have to manually set the Rust edition when using the `optee-utee-build` crate. However, Cargo is introducing a new environment variable, CARGO_PKG_EDITION, which will save us from having to set it redundantly.
   
   https://github.com/rust-lang/cargo/pull/14873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org


Re: [I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

Posted by "ivila (via GitHub)" <gi...@apache.org>.
ivila commented on issue #228:
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228#issuecomment-4181196371

   > > Can we just bump the MSRV to 1.82? The [documentation](https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-attributes.html?utm_source=chatgpt.com#details) notes that “Rust 1.82 added the ability in all editions to mark certain attributes as unsafe.”
   > 
   > Since we have already bumped the MSRV to 1.93, it should cover the feature introduced by Rust 1.82 for backward compatibility, right?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org


Re: [I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

Posted by "ivila (via GitHub)" <gi...@apache.org>.
ivila commented on issue #228:
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228#issuecomment-4174032500

   @DemesneGH Can we just bump the MSRV to 1.82? The [documentation](https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-attributes.html?utm_source=chatgpt.com#details) notes that “Rust 1.82 added the ability in all editions to mark certain attributes as unsafe.” 
   This allows us to remove the RustEdition parameter in `optee-utee-build`.
   
   Since this is a breaking change, I’d like to group it with other breaking changes (such as upgrading the `optee-utee-macros` crate to the 2024 edition, which requires developers to wrap macros with `unsafe`, e.g., `#[ta_create]` → `#[unsafe(ta_create)]`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org


Re: [I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

Posted by "ivila (via GitHub)" <gi...@apache.org>.
ivila closed issue #228: [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION`
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org


Re: [I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on issue #228:
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228#issuecomment-4175950674

   > Can we just bump the MSRV to 1.82? The [documentation](https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-attributes.html?utm_source=chatgpt.com#details) notes that “Rust 1.82 added the ability in all editions to mark certain attributes as unsafe.”
   
   Since we have already bumped the MSRV to 1.93, it should cover the feature introduced by Rust 1.82 for backward compatibility, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org


Re: [I] [TODO] Tracking on the new environment variable of `CARGO_PKG_EDITION` [teaclave-trustzone-sdk]

Posted by "DemesneGH (via GitHub)" <gi...@apache.org>.
DemesneGH commented on issue #228:
URL: https://github.com/apache/teaclave-trustzone-sdk/issues/228#issuecomment-4181478286

   Sure, sounds good!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org