You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 01:38:37 UTC

[GitHub] [arrow] rok commented on pull request #11818: ARROW-14822: [C++] Implement floor/ceil/round for temporal objects

rok commented on pull request #11818:
URL: https://github.com/apache/arrow/pull/11818#issuecomment-1003827840


   @lidavidm @jorisvandenbossche this now rounds time since epoch in local time ([see here](https://github.com/apache/arrow/blob/b93f0758cd24f23f20ee7b0939ff409f213a9df7/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc#L502-L523)). It works ok outside of DST and discussible within. It's a different approach to what e.g. Pandas does.
   I'm going to look into a better approach for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org